----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58599/#review172974 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On April 24, 2017, 6:46 p.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58599/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 6:46 p.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > TombstoneMessage serialization code assumes the member info in RVV to be > either membership-id or disk-id and uses this info while de-serializing. > When there is a mix of persistent and non-persistent region in the cluster > (between nodes), the above assumption will not hold good; resulting in data > serialization exception. > > When there is a mix of persistent and non-persistent region, the version info > is always generated from the persistent member. While constructing the > tombstone message, even though there is no tombstone version generated on > non-persistent member, it was added into the tombstone message, resulting in > mixed version source, causing deserialization failure. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedTombstoneOperation.java > 1759c86 > > geode-core/src/main/java/org/apache/geode/internal/cache/versions/RegionVersionVector.java > 2e01c00 > > geode-core/src/test/java/org/apache/geode/internal/cache/versions/TombstoneDUnitTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58599/diff/2/ > > > Testing > ------- > > Manual testing. > Added new dunit test. Verified the failure without change. > precheckin in progress. > > > Thanks, > > anilkumar gingade > >
