[
https://issues.apache.org/jira/browse/GEODE-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969357#comment-15969357
]
ASF GitHub Bot commented on GEODE-72:
-------------------------------------
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/456
GEODE-72 : Remove deprecated APIs from Geode
This PR fixes following
- GEODE-236 Remove deprecated CacheEvent methods
- GEODE-237 Remove EntryEvent deprecated methods
- GEODE-253 Remove deprecated EntryNotFoundInRegion
- GEODE-255 Remove deprecated DataSerializer.register(Class,byte)
- GEODE-258 Remove deprecated Cache.getLoggerI18n and getSecurityLoggerI18n
methods
- GEODE-260 Remove deprecated RemoteTransactionException
- GEODE-266 Remove deprecated ObjectSizerImpl
- GEODE-267 Remove deprecated ThreadInterruptedException
- GEODE-289 Remove deprecated LicenseException
Testing : Precheckin Passed with one failure
ExportLogsDUnitTest.testExportWithStartAndEndDateTimeFiltering
But When I ran this test individually from command line and IDE no failures
seen.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/geode feature/GEODE-72
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #456
----
commit e49b05a4b684b3b6f1cb40b692a6c0161058a8f9
Author: adongre <adon...@apache.org>
Date: 2017-04-13T02:15:29Z
GEODE-236: Removed deprecated CacheEvent methods
isExpiration and isDistributed removed from CacheEvent.
All the usage in the code and test are replaced with CacheEvent.getOperation
Refactored TXJUnitTest test for event property validations.
commit 2196bd5e3200baa08669fd25beba331b7982480d
Author: adongre <adon...@apache.org>
Date: 2017-04-13T02:20:39Z
GEODE-253: Removed depreated and not used EntryNotFoundInRegion class
commit f1e4b4366694729dd73006e26f2ca166b54f2e15
Author: adongre <adon...@apache.org>
Date: 2017-04-13T02:21:34Z
GEODE-260: Removed deprecated and not used RemoteTransactionException class
commit 844e83cc0b46b8fc35fae0802db2ed7f2713c6d7
Author: adongre <adon...@apache.org>
Date: 2017-04-13T02:23:42Z
GEODE-266: Removed ObjectSizerImpl and its usage is replace with
ObjectSizer.DEFAULT
commit caf4e2b033b2780323a18626fbb844a84fa97a60
Author: adongre <adon...@apache.org>
Date: 2017-04-13T02:24:38Z
GEODE-267: Removed deprecated ThreadInterruptedException class
commit 4d50c2a719f5d8eecab2ba1198784df0c1886fe2
Author: adongre <adon...@apache.org>
Date: 2017-04-13T02:25:26Z
GEODE-289: Removed depcreated LicenseException class
commit 81c019724ac4c735fbe89f44ebfbf2e63eb73da4
Author: adongre <adon...@apache.org>
Date: 2017-04-13T05:04:14Z
GEODE-237: Removed deprecated API from EntryEvent
1. isLocalLoad
2. isNetLoad
3. isLoad
4. isNetSearch
5. isBridgeEvent
commit 4f5177e2a7ebad6da8b573c0e14b48044f2c8de0
Author: adongre <adon...@apache.org>
Date: 2017-04-13T05:29:26Z
GEODE-255: Removed deprecated DataSerializer.register(Class,byte)
commit b9e851d355dff477037f1063b9b393108483431b
Author: adongre <adon...@apache.org>
Date: 2017-04-13T05:48:31Z
GEODE-258: Removed deprecated Cache.getLoggerI18n and getSecurityLoggerI18n
methods
commit 9cc3445fe88ce74a1ba665d71c2011cd676bf3e0
Author: adongre <adon...@apache.org>
Date: 2017-04-13T09:04:21Z
GEODE-258: ServerConnectionTest fails. Cache is created using mock which
does
not initializes the DistributedSystem. In this particular case
c.getLogger() will fail
with NPE. Guarding NPE in ServerConnection CTOR.
----
> Remove deprecated APIs from Geode
> ---------------------------------
>
> Key: GEODE-72
> URL: https://issues.apache.org/jira/browse/GEODE-72
> Project: Geode
> Issue Type: Improvement
> Affects Versions: 1.0.0-incubating
> Reporter: Bruce Schuchardt
> Labels: cleanup, docs
>
> The Geode APIs are riddled with old, deprecated interfaces, methods and
> settings inherited from GemFire. Unless there is a good reason to keep them
> shouldn't we remove them all before going out of incubation?
> Sub-tasks have been added for most items. Here are the remaining items not
> yet added:
> APIs deprecated in GemFire 5.1:
> * DLS.lockInterruptibly(), suspendLockingInterruptibly()
>
> APIs deprecated in an undocumented version prior to 5.7:
> * Use of hostname:port to specify a locator in gemfire.properties
>
> APIs deprecated after GemFire 5.7 and before 8.0
> * EvictionAlgorithm.LIFO_ENTRY, LIFO_MEMORY: these were deprecated but we
> never deprecated EvictionAttributes.createLIFOEntryAttributes
> nor EvictionAttributes.createLIFOMemoryAttributes. These algorithms are used
> internally by the product when a server create a queue to send subscription
> events to a client (see BridgeServerImpl.clientMessagesRegion). I think the
> algorithms were deprecated because we didn't intend to expose this internal
> feature as an external one. But they are exposed externally via
> EvictionAttributes so it is not clear that we can just delete them.
> The other consideration is that we do not have xsd support nor gfsh support
> for LIFO.
> * Region.getCache(): we should consider un-deprecating this. Customers were
> supposed to instead call Region.getRegionService but in lots of cases they
> would need to down cast that result to "Cache". Only clients that are calling
> ClientCache.createAuthenticatedView end up with Regions whose getCache throws
> UnsupportedOperationException. Our code call getCache from over 500 places.
> * Locator.startLocator(int, File), startLocator(int, File, InetAddress) etc.
> * Locator.getLocators(), hasLocators()
> APIs deprecated since GemFire 5.7 with no version information mentioned
> * DistributedRegionMXBean.getDiskTaskWaiting()
> * MemberMXBean.getCurrentHeapSize(), getMaximumHeapSize(), getFreeHeapSize()
> * RegionMXBean.getDiskReadsAverageLatency(), getDiskWritesAverageLatency(),
> getDiskTaskWaiting()
> Things that should be deprecated but are not:
> * MembershipAttributes and “required roles”.
> * DynamicRegions: if GEODE-215 is implemented then we could deprecate
> DynamicRegions and have an alternative to change to. We have some support in
> the gfsh/management layer for creating regions remotely which might be good
> enough to deprecate DynamicRegions. The question is should we remove
> com.gemstone.gemfire.cache.DynamicRegionFactory even though it has not been
> deprecated.
> Deprecated in 7.0 and not previously in this list:
> * UniversalMembershipListenerAdapter
> APIs deprecated in 8.0. It would probably be a nice gesture to Pivotal to
> keep these for a while to allow people to migrate from their GemFire product
> to Geode.
> * PutAllOperationContext.setMap()
> * FixedPartitionResolver.getPartitionName(EntryOperation, Set<String>)
> * ssl-enabled, ssl-protocols, ssl-ciphers, ssl-require-authentication,
> jmx-manager-ssl distribution properties
> * RegionMXBean.getAvgBucketSize()
> The Admin API and packages are also marked as deprecated but there seem to be
> some gfsh dependencies on this API, so I'm not sure if it can be removed.
> Also consider removing com.gemstone.gemfire.cache.partition.PartitionListener
> and com.gemstone.gemfire.cache.partition.PartitionManager.
> They have not been deprecated but were never fully supported. Their javadocs
> say:
> Note : Please contact supp...@gemstone.com before using these APIs
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
