----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58319/#review171491 -----------------------------------------------------------
Ship it! Ship It! - Ken Howe On April 10, 2017, 9:06 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58319/ > ----------------------------------------------------------- > > (Updated April 10, 2017, 9:06 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick > Rhomberg. > > > Bugs: GEODE-2267 > https://issues.apache.org/jira/browse/GEODE-2267 > > > Repository: geode > > > Description > ------- > > GEODE-2765: change gfsh help to consistently use log4j levels > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 67955dc61e87b8d485eaf191ce06eecdfb65cf39 > > geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties > af6b4bfac982cc5dd69f3d5254c6512264361e2b > > > Diff: https://reviews.apache.org/r/58319/diff/4/ > > > Testing > ------- > > * HelpCommandsIntegrationTest updated and passes > * precheckin in progress > > > Thanks, > > Kirk Lund > >
