Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/444#discussion_r110699099
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java
---
@@ -240,12 +240,37 @@ public boolean containsRegionContentChange() {
return true;
}
+ public long startOperation() {
--- End diff --
This and endOperation are missing javadocs, which I think are essential in
this case.
I don't think the callers of startOperation care that the return value is a
"viewVersion". I think you should change all of the methods invoking
startOperation to use "operationToken" instead of "viewVersion" so as not to
make that code confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
