[
https://issues.apache.org/jira/browse/GEODE-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961346#comment-15961346
]
ASF subversion and git services commented on GEODE-2684:
--------------------------------------------------------
Commit 6b2b7b2f7f3f63b8ae638e9afffa5edc0f763783 in geode's branch
refs/heads/feature/GEODE-2632 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6b2b7b2 ]
GEODE-2684 Connection & ConnectionTable cleanup
removed dead code and indirect access of TcpConduit through the
connection table.
> org.apache.geode.internal.tcp.Connection & ConnectionTable cleanup
> ------------------------------------------------------------------
>
> Key: GEODE-2684
> URL: https://issues.apache.org/jira/browse/GEODE-2684
> Project: Geode
> Issue Type: Task
> Components: membership
> Reporter: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> These classes contain a lot of commented-out code, poorly named methods and
> incorrect calculations that need to be cleaned up. For instance, Connection
> contains this:
> short aShort = -1;
> bytes[x] = (byte)(aShort & 0xff / 0x100);
> bytes[x+1] = (byte)(aShort & 0xff);
> which is incorrect and results in bytes[x] being zero when the intent is for
> it to be 255.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
