----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58213/#review171148 -----------------------------------------------------------
Ship it! I missed geode-assembly/src/main/dist/bin/ in my initial review. Thanks for the update Kirk. - Mark Bretl On April 5, 2017, 10:19 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58213/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 10:19 a.m.) > > > Review request for geode, Anthony Baker, Avinash Dongre, Mark Bretl, and Udo > Kohlmeyer. > > > Bugs: GEODE-2749 > https://issues.apache.org/jira/browse/GEODE-2749 > > > Repository: geode > > > Description > ------- > > GEODE-2749: don't ignore bin/ because we have bin/ in src > > $ find . -name 'bin' > ./extensions/geode-modules-assembly/release/session/bin <-- contains > modify_war script > ./extensions/geode-modules-tomcat8/bin <-- empty? > ./geode-assembly/src/main/dist/bin <-- contains our gfsh > scripts > > > Diffs > ----- > > .gitignore 31d5996b833bb3a32a0e2480e94335d5fa05a914 > gradle/rat.gradle 7bea470ae681492c61a76315ecad09a53c3f43fe > > > Diff: https://reviews.apache.org/r/58213/diff/1/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
