> On April 5, 2017, 2:31 p.m., Anthony Baker wrote: > > -1 > > > > There are several bin/ dirs with source files: > > > > ``` > > ~/code/incubator-geode (develop)$ find . -name bin -type d > > ./extensions/geode-modules-assembly/release/session/bin > > ./geode-assembly/src/main/dist/bin > > ``` > > > > This change will cause problems.
Changes were already committed. I have a partial revert ready and in review. Please see https://reviews.apache.org/r/58213/ - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58158/#review171122 ----------------------------------------------------------- On April 3, 2017, 7:57 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58158/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 7:57 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick > Rhomberg. > > > Bugs: GEODE-2749 > https://issues.apache.org/jira/browse/GEODE-2749 > > > Repository: geode > > > Description > ------- > > I installed new versions of Eclipse and IntelliJ and created geode projects > in both using the defaults for IDE output of compiled classes. They created > bin/ and out/ which were then failing rat and also showing up as untracked > files by git. > > I added both to .gitignore and the ignore list in gradle/rat.gradle and > tested with git status and ./gradlew rat. > > > Diffs > ----- > > .gitignore 38c813196f5 > gradle/rat.gradle c97a9e9dc78 > > > Diff: https://reviews.apache.org/r/58158/diff/1/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
