----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58187/ -----------------------------------------------------------
Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer. Repository: geode Description ------- Gfsh command line parameters were put into ThreadLocals to make them available to the XML parser. These are now held in non-thread-local variables so that all threads, including the auto-reconnect thread, can see them when building the cache. This diff also includes some minor refactoring in org.apache.geode.internal.tcp. It primarily removes some "this.owner.getConduit().doSomething" with "this.conduit.doSomething" and removes dead code. Diffs ----- extensions/geode-modules-tomcat8/src/test/java/org/apache/geode/modules/session/Tomcat8SessionsClientServerDUnitTest.java e475f40339e294ad48b403db1afa7aa624d5e80c geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 9435bd8178248c4fa34f6867d15a7cdfdec06d6b geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerLauncher.java 760abd3d946281d474502a9af2e8fe823a011329 geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java 1c3c93314841f5623c0e6387500af88f106328d9 geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java a0af24501a5081fe483160c5bf4fc7671545684e geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java 08a90096c0cf0348c0fa34b7ff8e18806810ab68 geode-core/src/main/java/org/apache/geode/internal/tcp/DirectReplySender.java 3872ee98ec24fe95894c0def538e3752136b05c3 geode-core/src/main/java/org/apache/geode/internal/tcp/MsgReader.java fc5627112ac8dd456976139d3750fd951812879b geode-core/src/main/java/org/apache/geode/internal/tcp/NIOMsgReader.java 50f5faedba056ec4f57124aefd56477dc11c1cf6 geode-core/src/test/java/org/apache/geode/cache30/ReconnectWithCacheXMLDUnitTest.java PRE-CREATION geode-core/src/test/resources/org/apache/geode/cache30/ReconnectWithCacheXMLDUnitTest.xml PRE-CREATION Diff: https://reviews.apache.org/r/58187/diff/1/ Testing ------- new test, precheckin Thanks, Bruce Schuchardt
