----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58080/ -----------------------------------------------------------
(Updated April 4, 2017, 8:41 p.m.) Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk Lund, and Patrick Rhomberg. Changes ------- Finally got test SizeExportLogsFunctionCacheTest.noFiles_returnsZeroResult to pass in precheckin. Thanks to Jinmei for help properly applying rules to ensure clean server startup and shutdown in the tests. Repository: geode Description ------- - New Function class added with tests - Code to invoke new function added, but disabled, in ExportLogsCommand - New option added, but disabled, for specifying size limit for exported logs - Refactoring: extracted the interceptor from ExportLogsCommand - Refactoring: renamed ExportLogCommand to ExportLogsCommand - New Serializable class to return the log size estimate to the command - Tests for the log sizing related classes This is work-in-progress that is adds sizing estimation for exported logs, but the code is currently not called by ExportLogsCommand. Follow-on work will use the new sizing estimation to provide warnings to the user if exporting logs may fill up disks on servers or the locator. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java 3f147c19a128dce78c51c31e6758e517cd2ab496 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptor.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java cbdf1c4bc28554a8fbec3740c566ee07c69b4ac9 geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfo.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 5b1f089c18c404f64929398f6015839eb783ccb4 geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogSizer.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java 95edd426da8b8f39bb1486661d8c307d43f170d6 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptorJUnitTest.java 573701fd7f48c8c1b72c0f71993a4adea7bdbe8b geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java 5a4d274a751a6e22fcfbc0c5e6bd5dff39e3b938 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LogLevelInterceptorTest.java 41b971534fd83c87f33751fa46454e158315f6ae geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfoTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionFileTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsTestSuite.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogSizerTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java 6ae82da58923fdf3a44217c1773a40d8ff1001bc geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt 2f5a5cdf8c59e90625fe01c3306462e9277ab4e1 geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 397ec14c0bbbea277d378eefcaecfdb90cc9e224 Diff: https://reviews.apache.org/r/58080/diff/3/ Changes: https://reviews.apache.org/r/58080/diff/2-3/ Testing ------- Precheckin is running I need to debug one test of the new class that is still failing: org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest > withFunctionError_shouldThrow FAILED org.apache.geode.GemFireConfigException: The locators attribute can not be empty when the mcast-port attribute is non-zero. at org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:558) at org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:299) at org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:206) at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:216) at org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146) Re-running precheckin after merging current develop to my branch. Thanks, Ken Howe
