[
https://issues.apache.org/jira/browse/GEODE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954176#comment-15954176
]
ASF GitHub Bot commented on GEODE-2725:
---------------------------------------
GitHub user PurelyApplied opened a pull request:
https://github.com/apache/geode/pull/438
GEODE-2725: export logs now honors --dir when connected via JMX, with
respect to the manager filesystem.
Removed --dir usage from ExportLogsDUnitTests:
startAndEndDateCanIncludeLogs and
testExportWithStartAndEndDateTimeFiltering; these tests expected logs
to appear in the locator working directory and the --dir option was
not actually being used.
Usage of LocalLocatorStarterRules reverted in
ExportLogsIntegrationTest as locator working directory access is
required.
-- Precheckin cleared green on Test, IntegrationTest, LegacyDUnitTest, and
FlakyTest. DistributedTest still running.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode geode-2725
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #438
----
commit e3925106249172b5c6dc6399966af54822ca879b
Author: Patrick Rhomberg <prhomb...@pivotal.io>
Date: 2017-04-03T18:24:57Z
GEODE-2725: export logs now honors --dir when connected via JMX, with
respect to the manager filesystem.
Absolute Paths are better. Test class inheritance is cumbersome.
Removed --dir usage from ExportLogsDUnitTests:
startAndEndDateCanIncludeLogs and
testExportWithStartAndEndDateTimeFiltering; these tests expected logs
to appear in the locator working directory and the --dir option was
not actually being used.
Usage of LocalLocatorStarterRules reverted in
ExportLogsIntegrationTest as locator working directory access is
required.
----
> export logs does not honor --dir
> --------------------------------
>
> Key: GEODE-2725
> URL: https://issues.apache.org/jira/browse/GEODE-2725
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh, logging
> Reporter: Swapnil Bawaskar
> Assignee: Patrick Rhomberg
>
> When connected to locator via jmx, run the following command:
> {noformat}
> gfsh>export logs --dir=tmp
> {noformat}
> Observer that the dir option is ignored:
> {noformat}
> Logs exported to the connected member's file system:
> /Users/sbawaskar/apache/geode/geode-assembly/build/install/apache-geode/loc1/exportedLogs_1490721273215.zip
> {noformat}
> The --tmp option is honored when connected via http.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
