GitHub user PurelyApplied opened a pull request:
https://github.com/apache/geode/pull/438
GEODE-2725: export logs now honors --dir when connected via JMX, with
respect to the manager filesystem.
Removed --dir usage from ExportLogsDUnitTests:
startAndEndDateCanIncludeLogs and
testExportWithStartAndEndDateTimeFiltering; these tests expected logs
to appear in the locator working directory and the --dir option was
not actually being used.
Usage of LocalLocatorStarterRules reverted in
ExportLogsIntegrationTest as locator working directory access is
required.
-- Precheckin cleared green on Test, IntegrationTest, LegacyDUnitTest, and
FlakyTest. DistributedTest still running.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode geode-2725
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #438
----
commit e3925106249172b5c6dc6399966af54822ca879b
Author: Patrick Rhomberg <[email protected]>
Date: 2017-04-03T18:24:57Z
GEODE-2725: export logs now honors --dir when connected via JMX, with
respect to the manager filesystem.
Absolute Paths are better. Test class inheritance is cumbersome.
Removed --dir usage from ExportLogsDUnitTests:
startAndEndDateCanIncludeLogs and
testExportWithStartAndEndDateTimeFiltering; these tests expected logs
to appear in the locator working directory and the --dir option was
not actually being used.
Usage of LocalLocatorStarterRules reverted in
ExportLogsIntegrationTest as locator working directory access is
required.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
