----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58155/#review170928 -----------------------------------------------------------
Ship it! Ship It! - Bruce Schuchardt On April 3, 2017, 6:31 p.m., Galen O'Sullivan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58155/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 6:31 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > And do some cleanup while I'm here: > * Change Mockito's `any` to `isA`. > * Replace some `Thread.sleep()` calls with Awaitility calls. > * Remove our `MethodExecuted` class -- this can be done with Mockito's > `verify()`. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > 05ab6f7e5 > > > Diff: https://reviews.apache.org/r/58155/diff/1/ > > > Testing > ------- > > Running precheckin. > > Ran the test suite in IntelliJ a few hundred times on my machine. > > > Thanks, > > Galen O'Sullivan > >
