> On March 30, 2017, 11:12 p.m., Dave Barnes wrote: > > Ship It!
Reduced the scope and accidentally opened another review board here: https://reviews.apache.org/r/58090/ - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58088/#review170656 ----------------------------------------------------------- On March 30, 2017, 10:26 p.m., Patrick Rhomberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58088/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 10:26 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, > Kirk Lund, and Swapnil Bawaskar. > > > Repository: geode > > > Description > ------- > > Various typos corrected, notably in --ignoreInterceptors (from > --ignoreInterCeptors), which is only referenced during command parsing. > > Many other typos corrected. Biggest offender: "occurred" has two Rs. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/DataSerializer.java > 627661a8ebbf5f8ffc6a5d2edff6c08f99a4035e > > geode-core/src/main/java/org/apache/geode/admin/internal/AbstractHealthEvaluator.java > 57b42a819a340348dfffd2fc5bcd0bc036f8aa1b > > geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteFunctionNoAckOp.java > def738938cc10546a157111ef93c6720cefbbdf2 > > geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteRegionFunctionNoAckOp.java > 06f02d1e6dd2250ef88cc794837905cd678052c0 > > geode-core/src/main/java/org/apache/geode/cache/client/internal/LiveServerPinger.java > 32d0f8e62096ed714f8eebae6b16f49e0a33e32c > > geode-core/src/main/java/org/apache/geode/cache/query/internal/AbstractCompiledValue.java > d635e024a9fa9cf8e3a7ae812744817ef071be13 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/AbstractGroupOrRangeJunction.java > 5ed4d865bdafc77817514b34735460f23d97f5d4 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledComparison.java > d47509fd88319ded7b7d8c223aeb72043688e5fc > > geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledIn.java > 0aa1efbaadb4a2334d48fbb8fe43785cc4ff8637 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledJunction.java > ece8a9dd2480b3cc706b5ec981076ae597bb44a4 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java > 9b775570ce01e696dc73b8523ff088e585ddf399 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/CompositeGroupJunction.java > 8f57ad6693a485ad061c93bf4732d62459a8b9e9 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/GroupJunction.java > 84971fd314987189eb249344cdc4ebf3fb4cff2f > > geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java > b9d6026c61209c3e32183f470de05ae41bd17285 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/QueryObserver.java > 2a965668fe564178a408b061a3c9623adf8040b2 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/QueryObserverAdapter.java > b4a92b0070c326b761f965f165a42556c1cd29ec > > geode-core/src/main/java/org/apache/geode/cache/query/internal/QueryUtils.java > 8eaa74a5dad5b8edbed28e9798a7f325fc9bffcf > > geode-core/src/main/java/org/apache/geode/cache/query/internal/RangeJunction.java > 42fb30d8f041f7c8924f5b6228a03c95f088f479 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/CqAttributesImpl.java > 7aeee1d95101a95284516a45395a678283eb91b2 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java > 96a3c833f4028cdd2e53c6fb7d74a169e8c8e465 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java > 80568f513c5fed3a03d6b6929cb2f3083ecad9aa > > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/HashIndex.java > 023fbb465960f366dbe901b586602ed961047b49 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexData.java > e5c516f5441198ca2f5a16bb6590b046f6530ff6 > > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/MemoryIndexStore.java > e9cd0709e224339ab46d2c3c17c87b3dcb96f1f8 > > geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java > 2c6c025043282b1e64418dced01eefc8d551fd9e > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java > 987e4911272ba6c37046d8e39a1187b71556736d > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java > 4ac2c9c705a344503fd247d39fbc980a27e2d403 > > geode-core/src/main/java/org/apache/geode/internal/cache/AbstractBucketRegionQueue.java > 60f397ccb36a01720128b1b398422b988511550d > > geode-core/src/main/java/org/apache/geode/internal/cache/AbstractDiskRegion.java > 554455d9db2269a7692f1e238ba373c94393d4e5 > > geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java > eaababaf6be6041c72156a338c69fa81f10db4c5 > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java > b97f4286b6e2352a4ec5637477641d868cb05a6c > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java > b9cdfd75c19f3425dacc8f99c1bc399248230b71 > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegionFunctionStreamingMessage.java > 1de8d3b3b97a090a549dbcd866436f8d571fe81e > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 15755175fc16609e0341d8c9e97039b5b83ce5d2 > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > 45540eebda466805bedc6ee08fc69203ae278c8b > > geode-core/src/main/java/org/apache/geode/internal/cache/MemberFunctionStreamingMessage.java > d0dd08466c0053dfd3f0b1dc58cc68c1c9ce01ad > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java > ca9468d503f5930fb20efa191335ba72d9b081ff > > geode-core/src/main/java/org/apache/geode/internal/cache/PRQueryProcessor.java > 6df39713fa7986e3ecd6e4c72bd0c7819235472c > > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java > 173f35c73d33c2e88d5b41e7a04055c423908127 > > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java > 5ddf0cb66e2f2e503336a2705a57a6000edd6128 > > geode-core/src/main/java/org/apache/geode/internal/cache/PlaceHolderDiskRegion.java > db01162aeeba8113c208565d683e71a41d0f6d00 > > geode-core/src/main/java/org/apache/geode/internal/cache/ProxyRegionMap.java > 92c7b6f8e90a3382e7ce00064581d69f9706fcd3 > > geode-core/src/main/java/org/apache/geode/internal/cache/UpdateEntryVersionOperation.java > f82f0ce5d92420f27ba8c260069221ee6605254c > > geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java > afc9a23aafba2c1f993b30546f24cd2b5d6a0126 > > geode-core/src/main/java/org/apache/geode/internal/cache/control/OffHeapMemoryMonitor.java > 414036747a5062ab556b60cdb58c5ce490312c78 > > geode-core/src/main/java/org/apache/geode/internal/cache/execute/AbstractExecution.java > 505dfce711a0931ec2c52050c121b70c5cb56334 > > geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionServiceStats.java > 09a9122c4058df477d14f03ba7e4c4024d259d6e > > geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionStats.java > 2f04034041fafa1f79e9c3f464270d4c4ea96e70 > > geode-core/src/main/java/org/apache/geode/internal/cache/execute/ServerToClientFunctionResultSender.java > 6b2177a411f0a283ddf15088aabe35b8bb863193 > > geode-core/src/main/java/org/apache/geode/internal/cache/ha/HARegionQueue.java > 70224f2e4884cf9769ab9dce3b8c4a248aba7ef2 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java > d7b923c55bfca019956a2bffb613e310310ebedd > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GatewayReceiverCommand.java > 2ccca7677a80e16a58edbe9ec43ae66317a9575a > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java > a604dbfae8d44bb95ff83598d7836a278e926f4b > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java > dfbd664298798ee83931faf80f7d85ae71d97e39 > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewayReceiverStats.java > ca345a98a13491cd399e255a8d71e888538a7e6c > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelQueueBatchRemovalMessage.java > 10a83b23c2f802c94e6334977ac07dada98f8c5d > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelQueueRemovalMessage.java > 921af9c08df99d954c238d8b05d6c3fb3e92e08b > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/BatchDestroyOperation.java > a368b60afb0f1bbcf73e550fd1257266d24f9515 > > geode-core/src/main/java/org/apache/geode/internal/datasource/AbstractDataSource.java > 25cfccb74e2e78e35640cc0b829971ca1c63fdf9 > > geode-core/src/main/java/org/apache/geode/internal/datasource/FacetsJCAConnectionManagerImpl.java > 318121c822a91c0ddb9679ca9e28075d53801e6b > > geode-core/src/main/java/org/apache/geode/internal/datasource/GemFireConnPooledDataSource.java > b9ea3f65ea9f7a6b3a619e07f61c4132cc1d3288 > > geode-core/src/main/java/org/apache/geode/internal/datasource/GemFireTransactionDataSource.java > 5ef3efd230931fff99e173327c531405ef6be2da > > geode-core/src/main/java/org/apache/geode/internal/datasource/JCAConnectionManagerImpl.java > d54d1a1ec0499502916d3b9994fc005e16b56b41 > > geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java > 499bf8e0700ca2ec621f9a4132ce54e2bf122fb2 > > geode-core/src/main/java/org/apache/geode/internal/jta/GlobalTransaction.java > b0c548ec1d61e83767239f32150c30bc204d80eb > > geode-core/src/main/java/org/apache/geode/internal/logging/LoggingThreadGroup.java > 7bb2d932596be29e210ae8109dcf84b95a12531b > geode-core/src/main/java/org/apache/geode/internal/tcp/MsgDestreamer.java > 860d55b55b89983f128d963ccff90ac4f2b2843e > geode-core/src/main/java/org/apache/geode/management/JVMMetrics.java > 388c8f623fa39f50217772b6ad729a7f9a059e26 > > geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/StatsKey.java > 32ce55b267d481ebf52b2e288476864e5f867640 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java > a1d03e45dd4d6559bd9a0869c7dd95908d1858ca > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java > bcbfcf0ca72876dbfb3d41613159aa051726870e > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > b37feabe6ed61c081e9653c94128f092ad189d10 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 5b1f089c18c404f64929398f6015839eb783ccb4 > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/AbstractCommandsController.java > e93363add9f9605d13263fb4b62030e3bc277466 > geode-core/src/test/java/batterytest/greplogs/ExpectedStrings.java > c598b7a84d060cabb3b378ffbbdfb2a803d7b375 > geode-core/src/test/java/org/apache/geode/JtaNoninvolvementJUnitTest.java > fc52fd85f229cc76439c79192b37439920b80238 > > geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java > 2d5a71be57122d236c7aa1d25272580ead97b786 > > geode-core/src/test/java/org/apache/geode/cache/partition/PartitionRegionHelperDUnitTest.java > 42367990edbf5ee7b6e1f3d66d8007b1a7b8cd65 > geode-core/src/test/java/org/apache/geode/cache/query/QueryJUnitTest.java > f08eef568d337ac30412e93d3b3671f548fad10c > > geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java > 620ab17032fdd740556001e670bba2e93b477e37 > > geode-core/src/test/java/org/apache/geode/cache/query/functional/MiscJUnitTest.java > 0555b7eaaeda33741aeae39b144d5522c5288935 > > geode-core/src/test/java/org/apache/geode/cache/query/functional/StructMemberAccessJUnitTest.java > 4da1e5204b743ddf5773e21d2397ce91bbe6bae7 > > geode-core/src/test/java/org/apache/geode/cache/query/internal/CompiledJunctionInternalsJUnitTest.java > 21745d5294ec4689f609185734da377dbea9f9c8 > > geode-core/src/test/java/org/apache/geode/cache/query/internal/IndexManagerJUnitTest.java > 929bd462ac7f4fe9b2c8fdc77f3f9e776701d9b7 > > geode-core/src/test/java/org/apache/geode/cache/query/internal/QueryUtilsJUnitTest.java > bb1366585a29459640d8499462becfef1890d5a5 > > geode-core/src/test/java/org/apache/geode/cache/query/internal/index/AsynchIndexMaintenanceJUnitTest.java > 3d3df4386c8cb1880ae6f9bc651a8bb25b25c135 > > geode-core/src/test/java/org/apache/geode/cache/query/internal/index/ConcurrentIndexInitOnOverflowRegionDUnitTest.java > 634e9bacd86370ab609165b7fc85f0e2ca81cf53 > > geode-core/src/test/java/org/apache/geode/cache/query/internal/index/HashIndexSetJUnitTest.java > 20fc1e13aef0744a69394daaa5699a8e06fdfb35 > > geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryCacheClosedJUnitTest.java > a7c1b9b6b07369f88caf2ac1b24ba8397964f437 > > geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryRegionClosedJUnitTest.java > 94718e08e0271e0e5ebec424277da04c414b4bd7 > > geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryRegionDestroyedJUnitTest.java > 4ddf27c0e9a7f9af7aaccd88a218f0479ea7a9cb > geode-core/src/test/java/org/apache/geode/cache30/DiskRegionDUnitTest.java > 81f3c78abe0428cd565dcf7a96f0f4204b475dfd > > geode-core/src/test/java/org/apache/geode/internal/cache/AbstractDistributedRegionJUnitTest.java > ba2f7943f9398a1126bacaa3885a089873bd8ad3 > > geode-core/src/test/java/org/apache/geode/internal/cache/Bug37377DUnitTest.java > 45498eb98bf86e227e71a2c03f0df136fe5f52d9 > > geode-core/src/test/java/org/apache/geode/internal/cache/ConcurrentFlushingAndRegionOperationsJUnitTest.java > dec404a09d196c71fe21d608a60971f5ebd7b45f > > geode-core/src/test/java/org/apache/geode/internal/cache/ConcurrentRegionOperationsJUnitTest.java > 643c8c9a549407f6af97b5fe33d1ed17fd79523d > > geode-core/src/test/java/org/apache/geode/internal/cache/ConcurrentRollingAndRegionOperationsJUnitTest.java > 8b36545e9f9f46642d34c1ac5b71875897fc6c38 > > geode-core/src/test/java/org/apache/geode/internal/cache/DeltaPropagationDUnitTest.java > 2e2ea7c40c01c5a9d3dd13372503e60c6591e49b > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskLruRegRecoveryJUnitTest.java > b91d2947ec5cf32bdc8df01bb43fd6e53101cfa7 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegOplogSwtchingAndRollerJUnitTest.java > c29b3f9b45be9dd3b5f733c9b0928d248b39ada0 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegRecoveryJUnitTest.java > dea84b59550eb055b8ab054890af86c261fd5e87 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionIllegalCacheXMLvaluesJUnitTest.java > 705742f2e505cbf64e79710ac4a7f2810cec48f3 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionJUnitTest.java > c3922a7598e7d1eed46a0285bcfd39fdf769d91e > > geode-core/src/test/java/org/apache/geode/internal/cache/MapInterface2JUnitTest.java > cea560e4804b66ca91abf775e7f45fc73a946bf9 > > geode-core/src/test/java/org/apache/geode/internal/cache/MapInterfaceJUnitTest.java > b005c8541bbe5d7073146528cd784f91e465692a > > geode-core/src/test/java/org/apache/geode/internal/cache/OplogJUnitTest.java > 02e0a82073a92323c57e0f3766a35ef728de2bd0 > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionDestroyDUnitTest.java > c22c68d410dab2b46b8931257aaba25646f6fbb2 > > geode-core/src/test/java/org/apache/geode/internal/cache/PersistentPartitionedRegionJUnitTest.java > bfdf1c025ed5ae06c69b2e3840e0fde34af23f09 > > geode-core/src/test/java/org/apache/geode/internal/cache/SimpleDiskRegionJUnitTest.java > e7b64a7b7ac4fa7c395b43e21d4b443e05b6a2b5 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/DistributedRegionFunctionExecutionDUnitTest.java > 49d67d230e1df19403fca14f5aca40174607a788 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionServiceStatsDUnitTest.java > d85b8107a0a10737dbe25141b120306d26e47778 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/MemberFunctionExecutionDUnitTest.java > 3fa944aca128069eac8278e05ba6b626c02b7a92 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionFailoverDUnitTest.java > bc7e0619fc0657f2c5ede806f0c5258d58bd0778 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionNoSingleHopDUnitTest.java > 0925bc5d152ea75a853d4668d3ab41194f0c99a5 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionSelectorNoSingleHopDUnitTest.java > 43540a8b369f0edce61f464333c567e9faef680d > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java > d5d3d6469596e6ee1cab13abe3d620d35960c9d7 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRFunctionExecutionDUnitTest.java > 9e9cc0c84c5dcaa8eecc75200378d1a52224ddf4 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRPerformanceTestDUnitTest.java > 7e2861f3495597846d6d3beb48d47ff1c5efb4df > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/BlockingHARegionJUnitTest.java > b802b8e3dc1310c1825e08487519a0370b83be39 > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/BlockingHARegionQueueJUnitTest.java > 125fb819c2b8cad4a7601e93b20e7396e9455224 > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug36853EventsExpiryDUnitTest.java > 081514d4742bf7333fce7a496a7348fe98a5ee07 > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/EventIdOptimizationDUnitTest.java > a2b624970a6632d6e3fedd893dc86f8b305ef90e > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARegionQueueDUnitTest.java > 14be90e5f8d7e27dac7f7c3a312e9b554f140364 > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARegionQueueJUnitTest.java > 796b27f28dd85d3b7a33e00bf14cce056efe3767 > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARegionQueueStartStopJUnitTest.java > 3445b330b3ec28c0c7b9c51cef660bac4fcf8859 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/HAInterestPart2DUnitTest.java > 346fe23597510f20336d9c49fc55bf152b0f056d > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/HAInterestTestCase.java > 544f732dea45dfc2bd6926fe7cac4530aeffaab8 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/InterestListDUnitTest.java > d8164f1b3eb6a0be55e4022298a3860cc654426c > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/NewRegionAttributesDUnitTest.java > eb603ca13006a2c4c5af5bff2368f8f4b23c7c93 > > geode-core/src/test/java/org/apache/geode/internal/datasource/CleanUpJUnitTest.java > 1a5447b5ea5e6113828b6e724d07840ef7596a61 > > geode-core/src/test/java/org/apache/geode/internal/datasource/ConnectionPoolCacheImplJUnitTest.java > 9a0916a8a861ba55e9511635093e414a264d24ce > > geode-core/src/test/java/org/apache/geode/internal/datasource/ConnectionPoolingJUnitTest.java > 8eac764b325fd5f5c5bc28338fa413d8d93b4629 > > geode-core/src/test/java/org/apache/geode/internal/jta/GlobalTransactionJUnitTest.java > db1100ff56c3d161d08672f0a19b5c5b00e6fa3c > > geode-core/src/test/java/org/apache/geode/internal/jta/dunit/ExceptionsDUnitTest.java > d672d222c948fb6e3c9157f000be4e18df374bab > > geode-core/src/test/java/org/apache/geode/internal/jta/dunit/TransactionTimeOutDUnitTest.java > 9f829070268d7cc65f74bcd855b154c79cd4c790 > > geode-core/src/test/java/org/apache/geode/internal/jta/dunit/TxnTimeOutDUnitTest.java > 8f243caa5521cf0cb8aabe816a73474df9ed8c29 > > geode-core/src/test/java/org/apache/geode/internal/jta/functional/CacheJUnitTest.java > dcc16cc884577a8ce4ed0da3717472eb2f50888f > > geode-core/src/test/java/org/apache/geode/security/ClientAuthorizationTestCase.java > 6e4c3bee5c628d39c803d42a1ef694b19e7e863c > > geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqEventImpl.java > d3cf6ce4213ee334fce4ce3cb34822ff99d0f84d > geode-docs/managing/troubleshooting/recovering_from_p2p_crashes.html.md.erb > 5b7751f7596125cc8b8039cdb7e6b1da8f025fb3 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java > 12b6172cbbc79651e972179532f2b79623a1992e > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java > e71388d134c96549ee9995c4c874615ee66fe7c1 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java > 9633b9a1f50df051b8fb9b4f4787a1d25a0ab019 > geode-pulse/src/main/webapp/scripts/lib/jquery-1.7.2.js > 3774ff986139c8a7534e14bc8987fe80418dcc1b > geode-pulse/src/main/webapp/scripts/pulsescript/common.js > 23e262b094b76175d6aa2e7ad78678a8aef8b8e9 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java > 0656dd882de8c21ac911944b1e23afcbb402c920 > > > Diff: https://reviews.apache.org/r/58088/diff/1/ > > > Testing > ------- > > precheckin running, but the majority were in string constants and comments. > > > Thanks, > > Patrick Rhomberg > >