----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58052/#review170499 -----------------------------------------------------------
Ship it! Let's merge this into develop as soon as possible so we can work together on a bunch more refactoring of these JUnit Rules. - Kirk Lund On March 29, 2017, 11:14 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58052/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 11:14 p.m.) > > > Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick > Rhomberg. > > > Repository: geode > > > Description > ------- > > * Introduced LocalServerStarterRule and LocalLocatorStarterRule to replace > LocatorStarterRule and ServerStarterRule. > * The new rules will *only* start a member through the rule's before() > method. Members will *never* be started on Rule instantiation. > * The new rules are backed by Builders that use AvailablePort.Keeper to > reserve the ports that a member will use when it eventually starts. The > Keepers are released just before starting the member, with the goal of > minimizing test flakiness caused by BindExceptions when a port is already in > use. > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java > 819315fcc54a7ac6ea36bcdba40849e2fd624d5c > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java > 3da514f1681e41d437c1af079a673c012f679c5e > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityWithSSLTest.java > 4d142bd6b7aa91b162a4fdf4e546df2d3285290e > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestServersJUnitTest.java > a6ba2b0720cd916a5d7f9ae5a65ce303390cc9ee > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java > b163d5c4c2bcbd2d0a331f8e43e5adf234789322 > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/HttpClientRule.java > d0b54b9de5759e1ba3ce78f4efaa547d391c29cf > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java > 5d716f31f144193e0daf9b06b1af0e07e29dfe2f > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > 0b3b1cef8fa54c8dcb4d2ec2e4f49e9f10d729a7 > > geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java > 2d5a71be57122d236c7aa1d25272580ead97b786 > geode-core/src/test/java/org/apache/geode/cache/ProxyJUnitTest.java > 8cd68dc2a5d91cc2e9e165d27189607624a8ee07 > > geode-core/src/test/java/org/apache/geode/cache/partition/PartitionRegionHelperDUnitTest.java > 42367990edbf5ee7b6e1f3d66d8007b1a7b8cd65 > > geode-core/src/test/java/org/apache/geode/cache/query/BaseLineAndCompareQueryPerfJUnitTest.java > a46e1c40f69e93220e81f2ee81634dc4db553a1e > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexDUnitTest.java > 29388003c0a601bec61073e272432b175bc86eec > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/RemoteQueryDUnitTest.java > 7d0b469e056fadbca15d0769ed606537902cb305 > > geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexWithSngleFrmAndMultCondQryJUnitTest.java > 2da970f5decb982eb04b21584e6c9b8a8f67a94d > > geode-core/src/test/java/org/apache/geode/cache/query/functional/LimitClauseJUnitTest.java > ef2aa3ec9f4c771f7b6b089d24f464370bf3254f > > geode-core/src/test/java/org/apache/geode/cache/query/internal/QueryUtilsJUnitTest.java > bb1366585a29459640d8499462becfef1890d5a5 > > geode-core/src/test/java/org/apache/geode/cache/query/internal/index/IndexMaintenanceJUnitTest.java > 3f4b30460fcc701803b21c4b57532389388e60bd > > geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryDUnitHelper.java > 0f63df5805d155c0cf3ee6a6d506aca21dac8631 > geode-core/src/test/java/org/apache/geode/cache30/CacheLoaderTestCase.java > 6822c899a5291557eb005e2668e908803cee3552 > geode-core/src/test/java/org/apache/geode/cache30/CacheXml66DUnitTest.java > 01143ff8ed7842899c742e3f0614345fb93f65f5 > geode-core/src/test/java/org/apache/geode/cache30/DiskRegionDUnitTest.java > 81f3c78abe0428cd565dcf7a96f0f4204b475dfd > geode-core/src/test/java/org/apache/geode/cache30/DiskRegionTestImpl.java > 6fefb553fbc4b24cf421948222c0e4bc955a3b91 > > geode-core/src/test/java/org/apache/geode/cache30/DistributedAckRegionCCEDUnitTest.java > 2687f34bc89ba5d43e06658bdb12ea8fb9afa12e > > geode-core/src/test/java/org/apache/geode/cache30/DistributedMulticastRegionDUnitTest.java > 6b425f326d730f356feacb71c119e6baac18feaf > > geode-core/src/test/java/org/apache/geode/cache30/GlobalRegionCCEDUnitTest.java > a5b3cf65fa59f645b9896f0ff3ed65910ae86706 > > geode-core/src/test/java/org/apache/geode/cache30/MultiVMRegionTestCase.java > 28ef7ffa1475f00e250617887cf023e0a61d6b5f > geode-core/src/test/java/org/apache/geode/cache30/RegionTestCase.java > d87cbd802bdad5976ff908af8adc2774b7dd65e4 > > geode-core/src/test/java/org/apache/geode/distributed/internal/Bug40751DUnitTest.java > b9a601d5d1bcb06256813fc91353a35d436ad606 > geode-core/src/test/java/org/apache/geode/disttx/DistTXDebugDUnitTest.java > 0d2f2b6f41e1b1dd829a41472206d0ccb6589a5e > > geode-core/src/test/java/org/apache/geode/internal/cache/CacheAdvisorDUnitTest.java > 2dcf8e9cf377aa6955aa342f83bc364b2afe8570 > > geode-core/src/test/java/org/apache/geode/internal/cache/DeltaSizingDUnitTest.java > be21fa3a19cacfd13ee1fc670780f73f666daff9 > > geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerDUnitTest.java > 3faf41f9d3cf941f51c3f31810419305564f357d > geode-core/src/test/java/org/apache/geode/internal/cache/PRTXJUnitTest.java > d2bad641a47f68edb22da0f89a04c462ab48cd33 > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java > 7fd470f46f6646f1d422712df9e3f956eedf9e19 > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionHADUnitTest.java > 304861bf5ff38e9138680b557d8ba55da859381d > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyZoneDUnitTest.java > 11ecae563686935f447472b89004d6b91edc9edf > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionStatsDUnitTest.java > e2328a4c1b626dc457ff4258bd148d4ca79752c8 > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionTestUtilsDUnitTest.java > e769b4c5659aa45ddfc3690467a00441c33550ec > > geode-core/src/test/java/org/apache/geode/internal/cache/control/RebalanceOperationDUnitTest.java > 5f1c7fe5aa90767c8009ef7a2596a4a0170f091b > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARQueueNewImplDUnitTest.java > 12e5819d3c2951f8851fc9c0121a15e6d3038e38 > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/Bug39356DUnitTest.java > 5705c09e27cb054ef8ab2cbf8d25c6fae529b4fb > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/ShutdownAllDUnitTest.java > 11254e74bd544d1c868ecf408ba592068f8a76a1 > > geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java > beb3a9a2ce743fb34aaa5886eca699021bfdf7fe > > geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java > 0940ea6661c55849cb9dc168327f6abca8c4292d > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36829DUnitTest.java > 69b8a79d44d2469b02666160cbcc1cb43710b9e0 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DataSerializerPropogationDUnitTest.java > f86b39f475737b6e18af5693bfaba267c36cebc5 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java > 98cb30967e1348f9e7777108eed6f13672fcf9f7 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/InstantiatorPropagationDUnitTest.java > 1fcb06a58e3eeb07c5e60d7b29bc342d8ddd705e > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/RedundancyLevelTestBase.java > 52a041b44563554d33a10d46120f2d7c0004f35c > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java > 268fa397db253f12c0effdbf6faa5e822730144c > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java > d980318f305c14c8977ef91a052cc9bd5f819549 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshMultilineCommandTest.java > fb4776ead69877a95df837d031a240593e3b6d09 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java > 5ef93de49ba4873a00315274472982a5cca9b3ce > > geode-core/src/test/java/org/apache/geode/management/internal/security/AccessControlMBeanJUnitTest.java > 614d90c594413cbca8ff19c84939184f57aed725 > > geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthenticationJUnitTest.java > 14781d563b2f3ce6111107004463704fb949181d > > geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java > 1e899e005adf69167bc2dd139ba3cbf8196b5bc3 > > geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanShiroJUnitTest.java > 34ac46cd67b2ec1b9f3045b7a66c9f72f3fc83a8 > > geode-core/src/test/java/org/apache/geode/management/internal/security/CliCommandsSecurityTest.java > eab5517a964b889a4570578836cabd7c8405a771 > > geode-core/src/test/java/org/apache/geode/management/internal/security/DataCommandsSecurityTest.java > d4910afdd3ca013d1d0b554ae3f247100815c3d3 > > geode-core/src/test/java/org/apache/geode/management/internal/security/DeployCommandsSecurityTest.java > 01c3a455daa6e004fd3388dc3ed69be091536df4 > > geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java > 8fcaaa0ef26d7d9a754d86bed71ebb5ec2b2c2ce > > geode-core/src/test/java/org/apache/geode/management/internal/security/GatewayReceiverMBeanSecurityTest.java > 3bd226696448d803a9458e46356927fdeb886fbb > > geode-core/src/test/java/org/apache/geode/management/internal/security/GatewaySenderMBeanSecurityTest.java > 9829e272b80792d917b9d4ac9df8aa4e5375b84e > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java > e84cb56efda10c52b7a1a8a021acebcb93586954 > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java > 348e2ea8cb49f79b0ce3b6e98852b609a58ff3eb > > geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameTest.java > 6334e7e79ec89218e1a14f7194d4f77e53a93b50 > > geode-core/src/test/java/org/apache/geode/management/internal/security/LockServiceMBeanAuthorizationJUnitTest.java > a5a88c2981fac3f8939237739567616a734b091e > > geode-core/src/test/java/org/apache/geode/management/internal/security/MBeanSecurityJUnitTest.java > f97cf2b34c21d6e85fcd4ef52dc43e5cbc756c4a > > geode-core/src/test/java/org/apache/geode/management/internal/security/ManagerMBeanAuthorizationJUnitTest.java > 9be9e029dc52735487f37ec4bb89d066326c7773 > > geode-core/src/test/java/org/apache/geode/management/internal/security/MemberMBeanSecurityJUnitTest.java > 2ee03e31a14cf28d26a1089133e9af54f63482a7 > geode-core/src/test/java/org/apache/geode/security/ClientAuthDUnitTest.java > 27b002b88a38acfee5cc2c75e07d03e8f94f90b3 > > geode-core/src/test/java/org/apache/geode/security/ClientContainsKeyAuthDUnitTest.java > f2398bf37c5e8b651d0950fe9ec9ce1fd6755067 > > geode-core/src/test/java/org/apache/geode/security/ClientDestroyInvalidateAuthDUnitTest.java > a25900e526cf1f4bd594030b6413d5ed4542e49c > > geode-core/src/test/java/org/apache/geode/security/ClientDestroyRegionAuthDUnitTest.java > 33c8d62f1147872e8595a43f41ab995533c6774d > > geode-core/src/test/java/org/apache/geode/security/ClientExecuteFunctionAuthDUnitTest.java > adc66d0a6978e523e1313069cdc775d8b2965342 > > geode-core/src/test/java/org/apache/geode/security/ClientExecuteRegionFunctionAuthDUnitTest.java > 1f88161a17dd671a3cc9cad9bd64a57629dcfbdc > > geode-core/src/test/java/org/apache/geode/security/ClientGetAllAuthDUnitTest.java > 8963ee2c7a6c05446d7d3bfabffe9973fe95c80f > > geode-core/src/test/java/org/apache/geode/security/ClientGetEntryAuthDUnitTest.java > 0f41cc6ebf66dd00d991c3d3c6e71b77c587046f > > geode-core/src/test/java/org/apache/geode/security/ClientGetPutAuthDUnitTest.java > 8f6330137b4a9137985167328e7142305658d03e > > geode-core/src/test/java/org/apache/geode/security/ClientRegionClearAuthDUnitTest.java > 7eae4415aeed6717765ec9bc744497f9231082e7 > > geode-core/src/test/java/org/apache/geode/security/ClientRegisterInterestAuthDUnitTest.java > fcd2697736943790eec15ff4f7266a19b68ade94 > > geode-core/src/test/java/org/apache/geode/security/ClientRemoveAllAuthDUnitTest.java > b649d7fc6a6dd5b07add08b3a46132abe64796e7 > > geode-core/src/test/java/org/apache/geode/security/ClientUnregisterInterestAuthDUnitTest.java > 4802c809cc6e5d23b8dd7f970061191806176bf8 > > geode-core/src/test/java/org/apache/geode/security/NoShowValue1PostProcessorDUnitTest.java > 480ab1c43332da8c1397c5a5773f1f819d4bae1f > > geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java > ad72fab0ce7af4ab5e7b94b368155a02e9c0ba01 > > geode-core/src/test/java/org/apache/geode/security/PostProcessorDUnitTest.java > a650a80dfcacf5e0a9045c7a986b0721b2453bb9 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocalLocatorStarterRule.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocalServerStarterRule.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterBuilder.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java > 29f60d7c841242722c67bb796f1762d8c57352ee > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterBuilder.java > PRE-CREATION > > geode-cq/src/test/java/org/apache/geode/cache/query/dunit/QueryMonitorDUnitTest.java > f298fae6f1840302bc98668a09e4a9b2ed0c0b5c > > geode-cq/src/test/java/org/apache/geode/internal/cache/ha/CQListGIIDUnitTest.java > 659c4a9461f1d40b84732efd095fa7147fd63238 > > geode-cq/src/test/java/org/apache/geode/management/CacheServerManagementDUnitTest.java > 2cd69ddc619a68fb151e6574bace7418a7d58d10 > geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDUnitTest.java > 11db8cfc18824feefbbe5b61436c2f65cf06302f > > geode-cq/src/test/java/org/apache/geode/security/CQPDXPostProcessorDUnitTest.java > 6c897d156896bfcce910e8453df42f5d38e5a6f6 > > geode-cq/src/test/java/org/apache/geode/security/CQPostProcessorDunitTest.java > 26eff48dd8cb59923bab2beb5304b0609cf962a4 > > geode-cq/src/test/java/org/apache/geode/security/ClientQueryAuthDUnitTest.java > 18749d4a27cc805adae737709e5c2035bf884e67 > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/QueryNamesOverHttpDUnitTest.java > f63cf127a39e2b5c23d80aa5753f1384dea04c40 > > > Diff: https://reviews.apache.org/r/58052/diff/1/ > > > Testing > ------- > > Precheckin is started (still running) > > > Thanks, > > Jared Stewart > >
