[
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945671#comment-15945671
]
ASF GitHub Bot commented on GEODE-2513:
---------------------------------------
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/75#discussion_r108496561
--- Diff:
docs/geode-native-docs/dotnet-caching-api/implementing-igfserializable.html.md.erb
---
@@ -31,21 +31,21 @@ Examples follow the procedure.
void ToData(DataOutput output)
```
- The `ToData` function is responsible for copying all of the data
fields for the object to the object stream. The `DataOutput` class represents
the output stream and provides methods for writing the primitives in a network
byte order. For details, see the API documentation for `DataOutput` at
[http://gemfire-apis.docs.pivotal.io](http://gemfire-apis.docs.pivotal.io).
+ The `ToData` function is responsible for copying all of the data
fields for the object to the object stream. The `DataOutput` class represents
the output stream and provides methods for writing the primitives in a network
byte order.
2. Implement the `FromData` function that consumes a data input stream
and repopulates the data fields for the object:
``` pre
void fromData (DataInput& input)
```
- The `DataInput` class represents the input stream and provides methods
for reading input elements. The `FromData` function must read the elements of
the input stream in the same order that they were written by `ToData`. For more
about this, see the API documentation for `DataInput` at
[http://gemfire-apis.docs.pivotal.io](http://gemfire-apis.docs.pivotal.io).
+ The `DataInput` class represents the input stream and provides methods
for reading input elements. The `FromData` function must read the elements of
the input stream in the same order that they were written by `ToData`.
3. Implement the `ClassId` function to return an integer which is unique
for your class (in the set of all of your user-defined classes).
## Simple BankAccount Class
-This example shows a simple class, `BankAccount`, that encapsulates two
`ints`: `customerId` and `accountId`:
+This example shows a simple class, `BankAccount`, that encapsulates the
two `ints` `customerId` and `accountId`:
--- End diff --
Maybe a comma between `ints` and `customerId`?
> Geode Native docs: rebrand to match open-source software
> --------------------------------------------------------
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
> Issue Type: Improvement
> Components: docs
> Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts
> that have been purged from the open-source code. Docs should be updated to
> match.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
