This change will not cause something to be serialized that was not before. So your example of a local region that did not serialize before will continue not to serialize.
On Mon, Mar 27, 2017 at 5:25 PM, Galen M O'Sullivan <gosulli...@pivotal.io> wrote: > * Are we 100% sure that this won't break anything? I'd hate to see a user > with some weird object that holds references to system internals putting it > into a local region and getting something else back. Or the user might be > expecting == to work. > > * I'm wary of serializing data when the customer isn't aware it's being > serialized. We at least need to consider the conditions under which it will > be autoserialized. > > * What do we think about making big changes like this and versioning? > Should this be a major version thing? > > * Anybody want to take a bet that I can break it? :) > > Galen > > On Mon, Mar 27, 2017 at 5:13 PM, Swapnil Bawaskar <sbawas...@pivotal.io> > wrote: > > > Thanks for the feedback! I have filed this JIRA: > > https://issues.apache.org/jira/browse/GEODE-2722 > > > > On Mon, Mar 27, 2017 at 3:44 PM Michael Stolz <mst...@pivotal.io> wrote: > > > > > As for the first point, I agree that the user shouldn't have to > configure > > > anything to get ReflectionBasedAutoSerializer by default. > > > > > > "Store my object on the server...I don't care how." > > > > > > and while we're at it... > > > > > > "Make it indexable and queryable" > > > > > > That's why PDX was invented. > > > > > > > > > -- > > > Mike Stolz > > > Principal Engineer, GemFire Product Manager > > > Mobile: +1-631-835-4771 <(631)%20835-4771> > > > > > > On Mon, Mar 27, 2017 at 3:58 PM, Swapnil Bawaskar < > sbawas...@pivotal.io> > > > wrote: > > > > > > > I believe it would be much better user experience if we just > serialized > > > > user's domain object without requiring the user to configure > anything. > > > > Currently, we require that the user specify that they want to use the > > > > ReflectionBasedAutoSerializer and the pattern that matches the domain > > > > objects. > > > > > > > > Looking at this code > > > > <https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a > > > > 90bd3803c2/geode-core/src/main/java/org/apache/geode/pdx/internal/ > > > > AutoSerializableManager.java#L213> > > > > it > > > > looks like the pattern can be made optional. Also, we can go ahead > and > > > > configure ReflectionBasedAutoSerializer to be set by default on Cache > > > > startup (if one is not specified already). We should also set > > > > pdx-read-serialized to true in this case. > > > > For advanced use cases where the user wishes to exclude certain > fields, > > > > they can specify the pattern. > > > > If the users are using DataSerializable, that should still take > > > precedence > > > > over PDX, so we won't break existing users. > > > > > > > > Are there any major concerns around this approach? > > > > > > > > Thanks! > > > > Swapnil. > > > > > > > > > >
