----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57894/ -----------------------------------------------------------
Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description ------- * using local mbs server connection will bypass all the mbean security checks * do not update the mbean attribute since pulse user has no cluster:write privilege at all * Created EmbeddedPulseRule for tests Diffs ----- geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java PRE-CREATION geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/HttpClientRule.java d0b54b9de5759e1ba3ce78f4efaa547d391c29cf geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java 0b3b1cef8fa54c8dcb4d2ec2e4f49e9f10d729a7 geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java e1666ecf38331983d8c47c4b46b3b7e87faaf854 geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java 12b6172cbbc79651e972179532f2b79623a1992e geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java e71388d134c96549ee9995c4c874615ee66fe7c1 geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/IClusterUpdater.java 3ec820769a897bfb4f10a76a86dd2ce54fba3b70 geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java 9633b9a1f50df051b8fb9b4f4787a1d25a0ab019 geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java b228e4a754100fe07c9dbec232d5e88809aefeef geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java 4d300f04ff82f701509d44b83dd46698dbc6035e geode-pulse/src/test/java/org/apache/geode/tools/pulse/controllers/PulseControllerJUnitTest.java ddd799f5158e1f4213b0b6b2de8e1853ba65ab74 Diff: https://reviews.apache.org/r/57894/diff/1/ Testing ------- precheckin running Thanks, Jinmei Liao