-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57820/
-----------------------------------------------------------

(Updated March 22, 2017, 7:48 p.m.)


Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
-------

get rid of the chaining of before calls. Get rid of the abstract test class. 
Delete the @Ignored tests


Repository: geode


Description
-------

* be able to configure the various aspects of the rules before starting the 
server when declaring the rules.
* delete the unnecessary abstract test classes
* allowing tests to use default ports if needed
* created HttpClientRule to ease the connection to to pulse server


Diffs (updated)
-----

  
geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java
 45a4b6d02a513297620b0f35af5ffb5f6e79deff 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameTest.java
 070e9057d7594255c984aab9f0222776798f8e64 
  geode-core/src/test/java/org/apache/geode/security/AbstractAuthDUnitTest.java 
f8d90db1e018c28f2c5a4dd319e1b628e1f8f63d 
  geode-core/src/test/java/org/apache/geode/security/ClientAuthDUnitTest.java 
a8ab5b750508f884842dc811ce552b28d58d35d6 
  
geode-core/src/test/java/org/apache/geode/security/ClientContainsKeyAuthDUnitTest.java
 9a34198c14e7cae5c64c3a445c6e9f6972d1082a 
  
geode-core/src/test/java/org/apache/geode/security/ClientDestroyInvalidateAuthDUnitTest.java
 71a81560f62b3fea9de95a6446bd63ebebb7f5d2 
  
geode-core/src/test/java/org/apache/geode/security/ClientDestroyRegionAuthDUnitTest.java
 2366e3d883b5bc582f8b3bfba2d2d8369d3dfbfb 
  
geode-core/src/test/java/org/apache/geode/security/ClientExecuteFunctionAuthDUnitTest.java
 ad6b22627a620aec84e0d58e79995b173ba64af5 
  
geode-core/src/test/java/org/apache/geode/security/ClientExecuteRegionFunctionAuthDUnitTest.java
 eb9de5df753e846c5d4593974bec0e053cdf9cf3 
  
geode-core/src/test/java/org/apache/geode/security/ClientGetAllAuthDUnitTest.java
 cec4de643d55a42702cca381b3ae2e43fcd14edf 
  
geode-core/src/test/java/org/apache/geode/security/ClientGetClientPRMetaDataAuthDUnitTest.java
 f4aa9c929665285e600743ffad74ba40d389c59c 
  
geode-core/src/test/java/org/apache/geode/security/ClientGetClientPartitionAttrAuthDUnitTest.java
 706e168c262b43f086bdcbfbdd39b759a3d5d7e8 
  
geode-core/src/test/java/org/apache/geode/security/ClientGetEntryAuthDUnitTest.java
 57fc26356669e29ebd31481a6e67843f788a4de5 
  
geode-core/src/test/java/org/apache/geode/security/ClientGetPutAuthDUnitTest.java
 2d5bfdc1c0bc012a6c784d68e34eb7baf08d4e97 
  
geode-core/src/test/java/org/apache/geode/security/ClientRegionClearAuthDUnitTest.java
 d5dbbdb1c26c4af26fa19f4466909f635871332d 
  
geode-core/src/test/java/org/apache/geode/security/ClientRegisterInterestAuthDUnitTest.java
 d74c7d058772b35868779f7de048158a45365d69 
  
geode-core/src/test/java/org/apache/geode/security/ClientRemoveAllAuthDUnitTest.java
 ecb32a705191b45273081bb6d39a63aa062111dd 
  
geode-core/src/test/java/org/apache/geode/security/ClientSizeAuthDUnitTest.java 
84c03997101fa51cf4b253824e4f107be9c96a60 
  
geode-core/src/test/java/org/apache/geode/security/ClientUnregisterInterestAuthDUnitTest.java
 8b99d584f5f872bcc67cd257d2fe0147a4d43081 
  
geode-core/src/test/java/org/apache/geode/security/NoShowValue1PostProcessorDUnitTest.java
 f7a08852b6c49379758c24f885b2e73c02beed8b 
  
geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java
 f8b17bc8d24b82f0b1dd19a428e7981b85a30509 
  
geode-core/src/test/java/org/apache/geode/security/PostProcessorDUnitTest.java 
ed16f0cf06f9aec4562fcc906328fc2209918513 
  geode-core/src/test/java/org/apache/geode/security/SecurityTestUtil.java 
PRE-CREATION 
  geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDUnitTest.java 
ce1782b324ffbb3175efe53f54c33fa847613193 
  
geode-cq/src/test/java/org/apache/geode/security/CQPDXPostProcessorDUnitTest.java
 0bafb6831ba9892fbcc8aef0eb023e4dcf7972a4 
  
geode-cq/src/test/java/org/apache/geode/security/CQPostProcessorDunitTest.java 
8510dce91dde9d77343c2274afecb52eca52d0cd 
  
geode-cq/src/test/java/org/apache/geode/security/ClientQueryAuthDUnitTest.java 
9d82ae94dc36c5884cbeec7f22adff8c6b200ef1 


Diff: https://reviews.apache.org/r/57820/diff/2/

Changes: https://reviews.apache.org/r/57820/diff/1-2/


Testing
-------

precheckin running


Thanks,

Jinmei Liao

Reply via email to