----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57823/#review169713 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On March 21, 2017, 10:25 p.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57823/ > ----------------------------------------------------------- > > (Updated March 21, 2017, 10:25 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons > StringUtils > > > Diffs > ----- > > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java > 5408a5651774a63c16f27722c6ff7bda25cbaaa8 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/controllers/PulseController.java > 9b24393792cc52773089e08db6f1739c0d2c553f > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java > 083731ba9e26e711b72f8bf0bdf470d9852aa663 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/DataBrowser.java > d20be590d12faf53f91a64ad0d96646b92dd118e > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java > 758ad4be1f41946b98283c45ac27a022c75a9f14 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionService.java > 2e0a6f4b40c789add5854690cfc0882ea41218a5 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterRegionsService.java > 79937425fa9ad4f90b1b3d8aa64d17975421106e > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/ClusterSelectedRegionService.java > e94ef631724b4a62d5a2486674fc7a2e5f746788 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberAsynchEventQueuesService.java > e421ea09e81843c037e0430089a3d1062a44e814 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberClientsService.java > 2486fd46dd7155a08353717ea965f10533312366 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberDetailsService.java > c311c67413eb74099a6f6f31b31555d9f9c86a2f > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberDiskThroughputService.java > 98d094fe646be181c4724f85b4eb72ef912f33b9 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGCPausesService.java > 1a34b0a9bb3d0942d11f975b714cff57bd002ddd > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java > c9b40fd5e9ecf64fcd262750797dc79cacd4ed11 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberHeapUsageService.java > 1a7c54f135ac6aa29983d66cf50b4c59294ece07 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberKeyStatisticsService.java > ef6ccb82f58637cb714de2cf06bdcb5f23f98f13 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberRegionsService.java > c8addd979d72bf472e487b090c751deb2fcd9ff5 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/SystemAlertsService.java > d7f119b711c3b6168d826d195c582f655f10af68 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/StringUtils.java > df7c5a5e5dde97fd726b46f7007121e0538bd01a > > > Diff: https://reviews.apache.org/r/57823/diff/1/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Kevin Duling > >
