----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57797/ -----------------------------------------------------------
(Updated March 21, 2017, 12:37 a.m.) Review request for geode, anilkumar gingade and Darrel Schneider. Changes ------- Fix review comments. Bugs: GEODE-2535 https://issues.apache.org/jira/browse/GEODE-2535 Repository: geode Description ------- Use the boolean flag to determine if an entry is in memory or on disk so that stats are correctly updated. Avoid negating keyId by using the boolean flag. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java e3e87ea geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java d00f7a0 geode-core/src/main/java/org/apache/geode/internal/cache/DiskId.java 8d2c675 geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 642eed3 geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 27f41a2 geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegRecoveryJUnitTest.java 3fd091b geode-core/src/test/java/org/apache/geode/internal/cache/OplogJUnitTest.java 7549ea7 Diff: https://reviews.apache.org/r/57797/diff/2/ Changes: https://reviews.apache.org/r/57797/diff/1-2/ Testing ------- precheckin. Thanks, Eric Shu