Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/61#discussion_r106755238
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1812,17 +1812,32 @@ std::string
CacheHelper::generateGeodeProperties(const std::string& path,
msg += "enable-network-partition-detection=false\n";
if (ssl) {
- msg += "jmx-manager-ssl-enabled=false\n";
- msg += "cluster-ssl-enabled=true\n";
- msg += "cluster-ssl-require-authentication=true\n";
- msg += "cluster-ssl-ciphers=TLS_RSA_WITH_AES_128_CBC_SHA\n";
- msg += "cluster-ssl-keystore-type=jks\n";
- msg += "cluster-ssl-keystore=" + keystore + "/server_keystore.jks\n";
- msg += "cluster-ssl-keystore-password=gemstone\n";
- msg += "cluster-ssl-truststore=" + keystore +
"/server_truststore.jks\n";
- msg += "cluster-ssl-truststore-password=gemstone\n";
- msg += "security-username=xxxx\n";
- msg += "security-userPassword=yyyy \n";
+ if (untrustedCert){
--- End diff --
Much like keystore is a parameter to this method, could this if-then-else
statement be collapsed to a single set of concatenations that use a (possibly
empty) prefix string, e.g., "untrusted_"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
