----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57660/#review169056 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java Line 1691 (original), 1691 (patched) <https://reviews.apache.org/r/57660/#comment241368> We should remove this comment as it doesn't make sense for Geode... geode-core/src/main/java/org/apache/geode/internal/cache/DiskId.java Line 561 (original), 561 (patched) <https://reviews.apache.org/r/57660/#comment241370> is it appropriate to say, not needed for persistent region...Or remove the comment as exception indicates that. geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java Line 706 (original), 706 (patched) <https://reviews.apache.org/r/57660/#comment241371> How about using, "isKeyIdNegative"... - anilkumar gingade On March 15, 2017, 8:14 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57660/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 8:14 p.m.) > > > Review request for geode, anilkumar gingade and Darrel Schneider. > > > Bugs: GEODE-2536 > https://issues.apache.org/jira/browse/GEODE-2536 > > > Repository: geode > > > Description > ------- > > markForWriting and unmarkForWriting should not used for persistent region. > needsToBeWritten always return false now for persistent region, as the > diskEntry either is being written to disk (sync) or sheduled to be written to > disk (async) > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntry.java > bde6a32 > geode-core/src/main/java/org/apache/geode/internal/cache/DiskId.java > e802ac9 > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java > cce8100 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskIdJUnitTest.java > 195c6a2 > > > Diff: https://reviews.apache.org/r/57660/diff/1/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
