----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57569/#review168910 -----------------------------------------------------------
Ship it! I like the comments on `securityLogAndRollAndVerify` - Jared Stewart On March 13, 2017, 10:32 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57569/ > ----------------------------------------------------------- > > (Updated March 13, 2017, 10:32 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, > and Patrick Rhomberg. > > > Bugs: GEODE-2645 > https://issues.apache.org/jira/browse/GEODE-2645 > > > Repository: geode > > > Description > ------- > > GEODE-2645: rewrite test to fix flakiness and improve readability > > Coverted test from dunit to faster integration test. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/cache30/CacheLogRollDUnitTest.java > 3a0becf41bbfbed124ee727cae2a83ec453f9d20 > > geode-core/src/test/java/org/apache/geode/internal/logging/CacheLogRollingIntegrationTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/57569/diff/1/ > > > Testing > ------- > > CacheLogRollingIntegrationTest > precheckin in progress > > > Thanks, > > Kirk Lund > >
