> On March 10, 2017, 6:06 p.m., Galen O'Sullivan wrote: > > I think I would rather keep the ping interval equal to the setting and make > > the other side more resilient to single missed pings. What is this pinging?
Client pings the server to keep connection open and server close the connection if there is no activity on that connection for time being. - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57482/#review168641 ----------------------------------------------------------- On March 9, 2017, 10:38 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57482/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 10:38 p.m.) > > > Review request for geode. > > > Repository: geode > > > Description > ------- > > Client ping thread wakes up every "ping-interval" and then it checks whether > someone already did some operation on that server or not, in the last > ping-interval. If there is some operation, then it doesn't ping server and > wakes up again after ping-interval. But if operation happens just start of > the previous ping-interval then client thread will ping server after more > then ping-interval. This can cause an issue. Thus to avoid this race > condition, now ping thread will wake up in ping-interval/2 and will make sure > it pings server. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/client/internal/LiveServerPinger.java > bcb8eec > > geode-core/src/test/java/org/apache/geode/cache/client/internal/ConnectionPoolImplJUnitTest.java > 272580d > > > Diff: https://reviews.apache.org/r/57482/diff/1/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
