[
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903827#comment-15903827
]
ASF GitHub Bot commented on GEODE-2636:
---------------------------------------
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/50#discussion_r105266335
--- Diff: src/quickstart/cpp/PdxSerializer.cpp ---
@@ -165,15 +165,15 @@ int main(int argc, char** argv) {
LOGINFO("Registered Person Query Objects");
// Populate the Region with some Person objects.
- Person* p1 = new Person("John", 1 /*ID*/, 23 /*age*/);
+ Person* p1 = new Person((char *)"John", 1 /*ID*/, 23 /*age*/);
--- End diff --
Those methods pass a string literal to a method whose first parameter is
char *. An alternative would be to modify the type of the parameter but that
was a more invasive change when the goal was to reduce the clutter in the log
that got in the way of determining the root cause.
> Update exemplary code to follow library renaming
> ------------------------------------------------
>
> Key: GEODE-2636
> URL: https://issues.apache.org/jira/browse/GEODE-2636
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Dodge
> Assignee: Michael Dodge
>
> The work done for GEODE-2508 needs to be accommodated in the template and
> quickstart code.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
