If so, we have to implement fromData() and toData() in LuceneResultStructImpl.java for K and V. But we don't know their type yet.
On Tue, Mar 7, 2017 at 2:25 PM, Dan Smith <dsm...@pivotal.io> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57206/#review168203 > ----------------------------------------------------------- > > > > It looks good - my one question is if this should be > DataSerializableFixedID or something like that, so that it can be > serialized more efficiently and we can manage backwards compatibility? > > - Dan Smith > > > On March 7, 2017, 10:03 p.m., xiaojian zhou wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/57206/ > > ----------------------------------------------------------- > > > > (Updated March 7, 2017, 10:03 p.m.) > > > > > > Review request for geode, Barry Oglesby and Dan Smith. > > > > > > Bugs: GEODE-2617 > > https://issues.apache.org/jira/browse/GEODE-2617 > > > > > > Repository: geode > > > > > > Description > > ------- > > > > If customer call a lucene query in a function, they need to define their > own Serializable class to collect results. This has been complained by > field engineer. > > > > It will not hurt to let LuceneResultStruct to extend Serializable > > > > > > Diffs > > ----- > > > > > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java > b922185 > > > > > > Diff: https://reviews.apache.org/r/57206/diff/1/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > xiaojian zhou > > > > > >
