----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57243/#review167899 -----------------------------------------------------------
Ship it! LGTM. I reviewed the diffs from the original to the latest (version 3) without examining the intermediate changes. As these changes appear that they won't break nightly builds (your precheckin passed), it would be great to get this merged so that further refinements to the export logs command behavior can be dealt with individually. - Ken Howe On March 3, 2017, 10:17 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57243/ > ----------------------------------------------------------- > > (Updated March 3, 2017, 10:17 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk > Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2414: Determine a mechanism to stream a zip file from server to locator > GEODE-2415: Write a function to return a zip file for a single server > GEODE-2418: enable gfsh to download file from http connection > GEODE-2267: add validation to the arguments and include export stats in the > command > GEODE-2267: use the config to determine where the logs and stats are > GEODE-2267: Enhance server/locator startup rules to include workingDir > > What's not done in this batch: > 1. If you are exporting without http connection, exported zip will be left on > the loator's working dir, currently we don't have a cleanup mechanism to > delete them. > 2. long running task may timeout the http connection. No test around this > scenario. > 3. No warning to the user if they are exporting a large quantity of logs. > 4. we are exporting all the .log and .gfs files and only those files. Other > file extensions are ignored. > 5. merge-log option is ignored > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java > 11d74c13311923357e82318b32bf0342e156e0c6 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/CommandRequest.java > b0242c9e8ee656001cf76155f4e727ece07666a2 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java > 12a0a64202ed56fb48e970066b9e8838b9d6bef3 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java > bd6772803b2f109b9ca0fc98e059c8a86464d85c > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java > e94af4f3f34e6fc43c86b23a942e30ac28d58505 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java > 91810e88ee19f938fd0c13116a4736e671d4df6a > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java > bbf0542b80469e11d21a2ed56f52ef9e647e91ea > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java > 4b827a9e9022d06553ee2441ed50acd72252fb77 > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ExportLogController.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/MiscellaneousCommandsController.java > ac912c82c873c443dd268f07e8874b5bd18fdd0b > > geode-core/src/test/java/org/apache/geode/management/internal/cli/AbstractCliAroundInterceptorJUnitTest.java > c938f0755142209150a5a91a3764c54b009bb3a3 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptorJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportStatsDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/57243/diff/3/ > > > Testing > ------- > > precheckin Successful with the latest changes > > > Thanks, > > Jinmei Liao > >
