Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/412#discussion_r104260160
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -360,6 +360,13 @@ private void processRequest(final Socket sock) {
versionOrdinal = (short)
GOSSIP_TO_GEMFIRE_VERSION_MAP.get(gossipVersion);
} else {
// Close the socket. We can not accept requests from a newer
version
+ try {
+ sock.getOutputStream().write("unknown protocol
version".getBytes());
--- End diff --
This situation should never happen. When we fetch the protocol version of
a Locator we use v5.7. Then we use the locator's protocol version in future
communications. We will never send a higher version number than the locator
knows how to handle.
For SSL, this text is nothing like the response to a HelloClient packet.
On machines I've tested on it results in either a SSLHandshakeException or a
SSLException hinting that the other end might be using plain text sockets.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
