----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57249/#review167876 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On March 3, 2017, 9:55 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57249/ > ----------------------------------------------------------- > > (Updated March 3, 2017, 9:55 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Kirk > Lund. > > > Repository: geode > > > Description > ------- > > Removed the --with-lsof option from netstat command to reduce the > command response size. Avoids OOME's on JVMs in the test environment > with small heaps. > > The original tests with lsof have been retained, but annotated with > @Ignore. > > This is a minor update to incorporate suggestions from review. > After discussion with klund, moving the test class out of the FlakyTest > category. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java > e987fc2 > > > Diff: https://reviews.apache.org/r/57249/diff/2/ > > > Testing > ------- > > Tested locally on JVMs with small heap to verify there are no OOMEs > Precheckin has been started. > > > Thanks, > > Ken Howe > >
