[
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886956#comment-15886956
]
ASF GitHub Bot commented on GEODE-2494:
---------------------------------------
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352781
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -108,21 +98,21 @@ CqQueryStatType::CqQueryStatType()
////////////////////////////////////////////////////////////////////////////////
CqQueryVsdStats::CqQueryVsdStats(const char* cqqueryName) {
- CqQueryStatType* regStatType = CqQueryStatType::getInstance();
+ auto& regStatType = CqQueryStatType::getInstance();
- StatisticsType* statsType = regStatType->getStatType();
+ StatisticsType* statsType = regStatType.getStatType();
- GF_D_ASSERT(statsType != NULL);
+ GF_D_ASSERT(statsType != nullptr);
--- End diff --
`static_assert` is a compile time assertion. In this case the assertion
can't be resolved at compile time since the variables and functions involved
are not `constexpr`, templates or other compiler resolved things.
> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> ----------------------------------------------------------------------------
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
> Issue Type: Sub-task
> Components: native client
> Reporter: Jacob S. Barrett
> Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}}
> class, {{spinlock_mutex}}. You can find several public domain examples of how
> to implement a {{spinlock_mutex}} that can be used with
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
