----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57057/#review166943 -----------------------------------------------------------
Fix it, then Ship it! Ship It! geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/PageableLuceneQueryResultsImpl.java (line 92) <https://reviews.apache.org/r/57057/#comment239034> Would using the keys.size() instead of the scores.size() be better here? geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java (line 389) <https://reviews.apache.org/r/57057/#comment239037> Maybe extract a variable for page size? - Jason Huynh On Feb. 25, 2017, 1:05 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57057/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2017, 1:05 a.m.) > > > Review request for geode, Barry Oglesby, Jason Huynh, nabarun nag, and > xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Instead of using getAll, fetch the values of a lucene query using a > function that calls getEntry. We can then avoid invoking the cache > loader. > > > Diffs > ----- > > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java > b50996be8eeb2677537ba7756e33fc199601b3fc > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java > cf7b2c9a3e0a78417fa192ceee57441e005536ea > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/PageableLuceneQueryResultsImpl.java > 5c5d8250cf9c31f0d29964fe5f12f3bae779500d > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/results/LuceneGetPageFunction.java > PRE-CREATION > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/results/MapResultCollector.java > PRE-CREATION > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java > 01bdca40a59422dc0700ff22e867db7717a374ea > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationDUnitTest.java > cfde4f23305e3e4c6419268d32b04e2c9db4f9db > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneQueryImplJUnitTest.java > 9f826d586479e9e56b9e7130a9f23e7f706693a7 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PageableLuceneQueryResultsImplJUnitTest.java > 35a4c9169714ff766a655255d471cb639b7a0404 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/results/LuceneGetPageFunctionTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/57057/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
