> On Feb. 24, 2017, 10:58 p.m., Dan Smith wrote: > > Nice! > > > > I'm a bit confused by the guava dependency. Are you saying that it is a > > transitive dependency of something else in geode-core:testCompile, and you > > are trying to change the version that is used? If so you should probably > > add a comment to that effect so that someone knows why guava is there in > > the first place.
We have two tests that use guava APIs. Geode-junit has one test that uses guava and geode-junit/build.gradle has an explicit dependency on com.google.guava:guava:21.0 Geode-core has one test that uses guava but there is no explicit dependency. geode-core/build.gradle defines com.pholser:junit-quickcheck-guava:0.7 as a dependency which transitively pulls in com.google.guava:guava:19.0 I thought it might be best to specify guava:21.0 in both geode-junit and geode-core. - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57050/#review166772 ----------------------------------------------------------- On Feb. 24, 2017, 9:37 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57050/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 9:37 p.m.) > > > Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin > Duling, Ken Howe, Mark Bretl, and Dan Smith. > > > Bugs: GEODE-2461 > https://issues.apache.org/jira/browse/GEODE-2461 > > > Repository: geode > > > Description > ------- > > GEODE-2461: remove unnecessary explicit dependencies > > * activation - transitive via javax.mail-api > * annotations - unused > * cdi-api - unused > * classmate - transitive via springfox (swagger) > * hadoop - unused > * hbase - unused > * hibernate - unused > * hibernate-commons-annotations - unused > * hsqldb - unused > * jline - transtive via spring-shell > * jsr305 - unused > * paranamer - transitive via jackson-module-paranamer > * quartz - unused > * scala - transitive via jackson-module-scala_2.10 > > Add explicit testCompile dependency for guava to geode-core so that tests > using guava API in both geode-junit and geode-core are using the same > versions. > > > Diffs > ----- > > geode-assembly/build.gradle 3452141b030e12a5dd0bbb130b6a6a47707b7cef > geode-core/build.gradle 8eba6d4e8f9c6b021b214171bac5e360a0c86e7a > geode-web-api/build.gradle 9c491a0d9250dfe0aa089f61a8e4148acdeec5a3 > gradle/dependency-versions.properties > 5153f0b1bde2cec3d54354b5075ba069cfbf1ab6 > > Diff: https://reviews.apache.org/r/57050/diff/ > > > Testing > ------- > > precheckin passed (100% green) > > > Thanks, > > Kirk Lund > >
