Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103045677
--- Diff: src/tests/cpp/fwklib/Timer.hpp ---
@@ -28,18 +28,18 @@
#ifdef _WIN32
-#include <time.h>
-#include <stdio.h>
-#include <stdlib.h>
+#include <ctime>
+#include <cstdio>
+#include <cstdlib>
#include <windows.h>
#include <winbase.h>
#endif
#ifdef _SOLARIS
-#include <time.h>
-#include <stdio.h>
+#include <ctime>
--- End diff --
Yeah. Still kinda messy with all the platform `ifdef`s. Because this code
isn't related to public headers, which is the focus of GEODE-2439, I won't
invest much time in fixing further.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
