> On Feb. 24, 2017, 3:45 a.m., Jared Stewart wrote: > > Is there any reason to merge this into develop before GEODE-2267 is > > complete? It seems like perhaps we might as well leave this work on a > > feature branch until it is ready to replace the old 'export logs' > > implementation.
agree. - Jinmei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56991/#review166642 ----------------------------------------------------------- On Feb. 24, 2017, 3:12 a.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56991/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 3:12 a.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk > Lund. > > > Repository: geode > > > Description > ------- > > I am putting this up for review for now. It's a big changeset which includes > the following JIRA tickets: basically it's using replicated region as a > communication channel to transfer logs from remote servers to the > jmx-manager/locator that initiates this command, and then gather all the logs > as a http response to send it back to the gfsh client: > > GEODE-2414: Determine a mechanism to stream a zip file from server to locator > GEODE-2415: Write a function to return a zip file for a single server > GEODE-2414: Create exportLogs region for all locators > GEODE-2418: enable gfsh to download file from http connection > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java > 11d74c13311923357e82318b32bf0342e156e0c6 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java > bbf0542b80469e11d21a2ed56f52ef9e647e91ea > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java > b53c53f91ed63a01bfaa1232d9e194481ae45664 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/MergeLogsTest.java > PRE-CREATION > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOverHttpDunit.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56991/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
