[ https://issues.apache.org/jira/browse/GEODE-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879766#comment-15879766 ]
ASF subversion and git services commented on GEODE-2523: -------------------------------------------------------- Commit fa5963a3e6099136c3de70625b162ade3c1c5be0 in geode's branch refs/heads/develop from [~huynhja] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fa5963a ] GEODE-2523: Combined RegionTestableTypes into a "paired" enum type * Fixed accessor type attributes, now setting to valid 0 size * Readded fixed partition variant to existing test for gii > Collapse RegionTestableTypes combinations into a single enum types > ------------------------------------------------------------------ > > Key: GEODE-2523 > URL: https://issues.apache.org/jira/browse/GEODE-2523 > Project: Geode > Issue Type: Sub-task > Components: lucene > Reporter: Jason Huynh > > Currently, we have pairs of RegionTestableTypes that are used in the > LuceneDUnit tests. These pairs are used to determine the datastore and > accessor region types. However the pairings are generally 1 to 1. So we > should be able to collapse the types into a single enum and remove the > parameterized methods. Instead we should then be able to add the enum name > into the parameters themselves. > So instead of having the following for a test case > @Parameters(method = "getListOfClientServerTypes") > We could then have > @Parameters({"PARTITION", "ETC..."}) > we can probably use PARTITION and know that the corresponding client type is > PARTITION_PROXY. That or we can change the enum to be explicit about the > pairing, such as PARTITION_WITH_PARTITION_PROXY. -- This message was sent by Atlassian JIRA (v6.3.15#6346)