----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56936/#review166440 -----------------------------------------------------------
Ship it! Ship It! - Dan Smith On Feb. 22, 2017, 11:06 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56936/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 11:06 p.m.) > > > Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, > Dan Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > * Thought we should change the name of the LuceneFunction to describe that > the function is actually for querying. > * Changed the exception thrown type to > InternalFunctionInvocationTargetException to piggy back on the function > execution retry mechanisms (so we can remove the while loop in our > LuceneQueryImpl) > > > Diffs > ----- > > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java > b41bb5f > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java > f1b1861 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java > 76c5893 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java > PRE-CREATION > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/package-info.java > f6c1018 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneQueryImplJUnitTest.java > 4a31e96 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplIntegrationTest.java > 9e3a13c > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionContextJUnitTest.java > 1a6ed59 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java > fe05248 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionContextJUnitTest.java > PRE-CREATION > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56936/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
