----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56899/#review166279 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java (line 210) <https://reviews.apache.org/r/56899/#comment238198> You can use StringUtils.isBlank(name) to do it. Just FYI. - Jinmei Liao On Feb. 21, 2017, 9:27 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56899/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 9:27 p.m.) > > > Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Kevin > Duling, and Ken Howe. > > > Bugs: GEODE-2514 > https://issues.apache.org/jira/browse/GEODE-2514 > > > Repository: geode > > > Description > ------- > > GEODE-2514: add new tests for statistics archive rolling and removal > > * add MainWithChildrenRollingFileHandlerIntegrationTest > * add StatArchiveHandlerIntegrationTest > * expand DiskSpaceLimitIntegrationTest > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java > 20d1c4ff92fbd54956334c923e1bacfea8825aa6 > > geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveHandler.java > 3eb9730a31e5acaed5416c70425b7d8c46096187 > > geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java > 1702d9a46082de2bd219ca8716734f65fe046917 > > geode-core/src/test/java/org/apache/geode/internal/statistics/StatArchiveHandlerIntegrationTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56899/diff/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
