Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/390#discussion_r102340380
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
---
@@ -773,6 +755,73 @@ public void
clientIsPreventedFromConnectingToLocatorAsServer() throws Exception
}
+ private void proxyRegionClientServerOp(RegionShortcut shortcut) throws
Exception {
+ // start server first
+ final String REGION_NAME = "proxyRegionClientServerOp";
+ PORT1 = initServerCache(false);
+ // Create regions on servers.
+ server1.invoke(new SerializableCallable() {
--- End diff --
SerializableRunnable supports "public void run() throws Exception" so
there's no need to use SerializableCallable unless you need to return a type.
You also don't really need to 1st assertNotNull since c.createRegionFactory
will throw NPE:
```Java
server1.invoke(() -> {
Cache c = CacheFactory.getAnyInstance();
Region<Object, Object> r =
c.createRegionFactory(shortcut).create(REGION_NAME);
assertNotNull(r);
});
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
