[
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872264#comment-15872264
]
ASF GitHub Bot commented on GEODE-2497:
---------------------------------------
GitHub user bschuchardt opened a pull request:
https://github.com/apache/geode/pull/402
GEODE-2497 surprise members are never timed out during startup
Moved the creation of the timer to GMSMembershipManager.started()
Removed write-lock in timer-creation method since it's only called from
one place now
Altered the way that the timer-creation method finds the
InternalDistributedSystem. The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.
Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.
Altered the surprise-member unit test to run faster. It now completes in
under 10 seconds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-2497
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #402
----
commit 8d45ca22737282abe279d3c863478f904f2e1926
Author: Bruce Schuchardt <bschucha...@pivotal.io>
Date: 2017-02-17T18:17:21Z
GEODE-2497 surprise members are never timed out during startup
Moved the creation of the timer to GMSMembershipManager.started()
Removed write-lock in timer-creation method since it's only called from
one place now
Altered the way that the timer-creation method finds the
InternalDistributedSystem. The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.
Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.
Altered the surprise-member unit test to run faster. It now completes in
under 10 seconds.
----
> surprise members are never timed out during startup
> ---------------------------------------------------
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
> Issue Type: Bug
> Components: membership
> Reporter: Bruce Schuchardt
> Assignee: Bruce Schuchardt
>
> A system was observed to hang during startup when a "surprise member" was
> added but then never timed out. The system hung waiting for a response to a
> startup message sent to the surprise member.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
