----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56767/#review165900 -----------------------------------------------------------
Ship it! fix and ship it. - xiaojian zhou On Feb. 16, 2017, 9:15 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56767/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2017, 9:15 p.m.) > > > Review request for geode, Jason Huynh, nabarun nag, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Adding a callback argument when writing to the file and chunk regions. > The file and chunk regions now have a partition listener to > route the put to the correct bucket. > > The reason for all of this is that in some cases, the core code can can > send a message that only includes the PR id and the key. We need want > the core to be able to resolve the correct bucket from just those > things, which requires having the PartitionListener that uses the > callback argument. > > Note that I'm still writing directly to the BucketRegions, rather than > the partition region. I had some changes to write to the partitioned region, > but I'm seeing some filesystem corruption with those changes so I'd like > to just get this much in at that point. > > Added a test of putting to the file and chunk regions during GII, which > is the case where the core code sends a message that includes only the PR id > and the key. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java > 3ec8152cfe43b7499fe52ba31bdf2d9e1df2d48f > geode-core/src/main/java/org/apache/geode/internal/cache/LocalDataSet.java > c4858dc168a0c26750e28dff280197bad3164185 > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > 00401e9ac7adfd5e3e8962476bddc6c9a8281af4 > > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java > 44f84277363b9e8f6bba8407c7f02609a2c2150d > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java > 57dd0a56882b4087770348c3f58df29df9fdc893 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java > 53b4e083372127ef5670324bf3b687986d7f58bf > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/directory/RegionDirectory.java > 362cf932f265cd4b6095cc1c790b7f1bcbc3b259 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/FileSystem.java > f3975bf4bae8e28d6a9329788e939f101e857897 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/partition/BucketTargetingFixedResolver.java > PRE-CREATION > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/partition/BucketTargetingMap.java > PRE-CREATION > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/partition/BucketTargetingResolver.java > PRE-CREATION > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java > f1ee9871911f7ecfd3084c464ed8b67e9f28800a > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java > 931edc5269fc29de8e29f3099314a12959644f3b > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerFixedPRDUnitTest.java > dd9fa6b71f1bceccaec56eef1c6b5adc7c88c550 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java > 496721a5c2534e543f4f68d2285cf6e211cd5505 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java > 78909034138d9188b19067b5112e4c366750581b > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/partition/BucketTargetingMapTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56767/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
