[ https://issues.apache.org/jira/browse/GEODE-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869141#comment-15869141 ]
Jacob S. Barrett commented on GEODE-2492: ----------------------------------------- {noformat} Description Resource Path Location Type using declarations in the global namespace in headers are prohibited [google-global-names-in-headers] StatisticDescriptor.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 25 C/C++ Problem using declarations in the global namespace in headers are prohibited [google-global-names-in-headers] StatisticsType.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 25 C/C++ Problem non-const reference parameter 'vregex', make it const or use a pointer [google-runtime-references] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1045 C/C++ Problem non-const reference parameter 'vlist', make it const or use a pointer [google-runtime-references] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1038 C/C++ Problem non-const reference parameter 'vl', make it const or use a pointer [google-runtime-references] CqAttributes.hpp /geode-native/src/cppcache/include/gfcpp line 58 C/C++ Problem non-const reference parameter 'visitor', make it const or use a pointer [google-runtime-references] Properties.hpp /geode-native/src/cppcache/include/gfcpp line 107 C/C++ Problem non-const reference parameter 'vec', make it const or use a pointer [google-runtime-references] QueryService.hpp /geode-native/src/cppcache/include/gfcpp line 137 C/C++ Problem non-const reference parameter 'vc', make it const or use a pointer [google-runtime-references] Region.hpp /geode-native/src/cppcache/include/gfcpp line 989 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 89 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 100 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 115 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 130 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 141 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 150 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 161 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 172 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 183 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 194 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 205 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 407 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 439 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Properties.hpp /geode-native/src/cppcache/include/gfcpp line 50 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 45 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 54 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 84 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 94 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 104 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 114 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 124 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 134 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 142 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 151 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 160 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 170 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 182 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 194 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 204 C/C++ Problem non-const reference parameter 'value', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 217 C/C++ Problem non-const reference parameter 'v', make it const or use a pointer [google-runtime-references] Region.hpp /geode-native/src/cppcache/include/gfcpp line 956 C/C++ Problem non-const reference parameter 'v', make it const or use a pointer [google-runtime-references] Region.hpp /geode-native/src/cppcache/include/gfcpp line 983 C/C++ Problem non-const reference parameter 'system', make it const or use a pointer [google-runtime-references] CacheFactory.hpp /geode-native/src/cppcache/include/gfcpp line 473 C/C++ Problem non-const reference parameter 'system', make it const or use a pointer [google-runtime-references] CacheFactory.hpp /geode-native/src/cppcache/include/gfcpp line 495 C/C++ Problem non-const reference parameter 'sr', make it const or use a pointer [google-runtime-references] Region.hpp /geode-native/src/cppcache/include/gfcpp line 255 C/C++ Problem non-const reference parameter 'securityprops', make it const or use a pointer [google-runtime-references] AuthInitialize.hpp /geode-native/src/cppcache/include/gfcpp line 58 C/C++ Problem non-const reference parameter 'rs', make it const or use a pointer [google-runtime-references] Execution.hpp /geode-native/src/cppcache/include/gfcpp line 109 C/C++ Problem non-const reference parameter 'routingObj', make it const or use a pointer [google-runtime-references] Execution.hpp /geode-native/src/cppcache/include/gfcpp line 108 C/C++ Problem non-const reference parameter 'resultOfSingleExecution', make it const or use a pointer [google-runtime-references] ResultCollector.hpp /geode-native/src/cppcache/include/gfcpp line 91 C/C++ Problem non-const reference parameter 'regions', make it const or use a pointer [google-runtime-references] RegionService.hpp /geode-native/src/cppcache/include/gfcpp line 108 C/C++ Problem non-const reference parameter 'region', make it const or use a pointer [google-runtime-references] RegionEntry.hpp /geode-native/src/cppcache/include/gfcpp line 70 C/C++ Problem non-const reference parameter 'ptr', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 663 C/C++ Problem non-const reference parameter 'ptr', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 671 C/C++ Problem non-const reference parameter 'ptr', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 972 C/C++ Problem non-const reference parameter 'PersistenceInfo', make it const or use a pointer [google-runtime-references] PersistenceManager.hpp /geode-native/src/cppcache/include/gfcpp line 75 C/C++ Problem non-const reference parameter 'PersistenceInfo', make it const or use a pointer [google-runtime-references] PersistenceManager.hpp /geode-native/src/cppcache/include/gfcpp line 101 C/C++ Problem non-const reference parameter 'PersistenceInfo', make it const or use a pointer [google-runtime-references] PersistenceManager.hpp /geode-native/src/cppcache/include/gfcpp line 116 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializable.hpp /geode-native/src/cppcache/include/gfcpp line 58 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 39 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 49 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 58 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 68 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 78 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 88 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 98 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 108 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 118 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 128 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 138 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 146 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 155 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 164 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 176 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 189 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 198 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 211 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 225 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 232 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 254 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 314 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 351 C/C++ Problem non-const reference parameter 'output', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 395 C/C++ Problem non-const reference parameter 'out', make it const or use a pointer [google-runtime-references] Delta.hpp /geode-native/src/cppcache/include/gfcpp line 67 C/C++ Problem non-const reference parameter 'newListeners', make it const or use a pointer [google-runtime-references] CqAttributesMutator.hpp /geode-native/src/cppcache/include/gfcpp line 71 C/C++ Problem non-const reference parameter 'me', make it const or use a pointer [google-runtime-references] Region.hpp /geode-native/src/cppcache/include/gfcpp line 991 C/C++ Problem non-const reference parameter 'lhs', make it const or use a pointer [google-runtime-references] CacheAttributes.hpp /geode-native/src/cppcache/include/gfcpp line 93 C/C++ Problem non-const reference parameter 'lhs', make it const or use a pointer [google-runtime-references] RegionAttributes.hpp /geode-native/src/cppcache/include/gfcpp line 324 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 693 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 710 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 714 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 718 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 722 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 726 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 730 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 734 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 738 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 800 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 817 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 975 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 218 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 235 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 253 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 266 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 279 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 292 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 305 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 318 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 332 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 345 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 382 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 395 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 212 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 226 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 237 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 249 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 262 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 275 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 288 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 300 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 312 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 325 C/C++ Problem non-const reference parameter 'length', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 340 C/C++ Problem non-const reference parameter 'len', make it const or use a pointer [google-runtime-references] CacheableString.hpp /geode-native/src/cppcache/include/gfcpp line 272 C/C++ Problem non-const reference parameter 'len', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 64 C/C++ Problem non-const reference parameter 'len', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 74 C/C++ Problem non-const reference parameter 'key', make it const or use a pointer [google-runtime-references] Properties.hpp /geode-native/src/cppcache/include/gfcpp line 50 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] CacheableBuiltins.hpp /geode-native/src/cppcache/include/gfcpp line 313 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializable.hpp /geode-native/src/cppcache/include/gfcpp line 64 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 44 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 54 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 63 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 73 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 83 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 93 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 103 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 113 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 123 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 133 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 142 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 151 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 160 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 169 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 182 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 194 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 204 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 216 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 239 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 246 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 268 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 337 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 379 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 418 C/C++ Problem non-const reference parameter 'input', make it const or use a pointer [google-runtime-references] Struct.hpp /geode-native/src/cppcache/include/gfcpp line 148 C/C++ Problem non-const reference parameter 'in', make it const or use a pointer [google-runtime-references] Delta.hpp /geode-native/src/cppcache/include/gfcpp line 80 C/C++ Problem non-const reference parameter 'fieldValues', make it const or use a pointer [google-runtime-references] Struct.hpp /geode-native/src/cppcache/include/gfcpp line 53 C/C++ Problem non-const reference parameter 'encodedLen', make it const or use a pointer [google-runtime-references] CacheableString.hpp /geode-native/src/cppcache/include/gfcpp line 272 C/C++ Problem non-const reference parameter 'encodedLen', make it const or use a pointer [google-runtime-references] DataOutput.hpp /geode-native/src/cppcache/include/gfcpp line 753 C/C++ Problem non-const reference parameter 'encodedLen', make it const or use a pointer [google-runtime-references] DataOutput.hpp /geode-native/src/cppcache/include/gfcpp line 763 C/C++ Problem non-const reference parameter 'elementLength', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 423 C/C++ Problem non-const reference parameter 'diskProperties', make it const or use a pointer [google-runtime-references] PersistenceManager.hpp /geode-native/src/cppcache/include/gfcpp line 91 C/C++ Problem non-const reference parameter 'csPtr', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 626 C/C++ Problem non-const reference parameter 'csptr', make it const or use a pointer [google-runtime-references] RegionEntry.hpp /geode-native/src/cppcache/include/gfcpp line 78 C/C++ Problem non-const reference parameter 'cqListeners', make it const or use a pointer [google-runtime-references] CqAttributesFactory.hpp /geode-native/src/cppcache/include/gfcpp line 91 C/C++ Problem non-const reference parameter 'cqAttributes', make it const or use a pointer [google-runtime-references] CqAttributesFactory.hpp /geode-native/src/cppcache/include/gfcpp line 73 C/C++ Problem non-const reference parameter 'cqAttr', make it const or use a pointer [google-runtime-references] QueryService.hpp /geode-native/src/cppcache/include/gfcpp line 90 C/C++ Problem non-const reference parameter 'cqAttr', make it const or use a pointer [google-runtime-references] QueryService.hpp /geode-native/src/cppcache/include/gfcpp line 123 C/C++ Problem non-const reference parameter 'cptr', make it const or use a pointer [google-runtime-references] CacheFactory.hpp /geode-native/src/cppcache/include/gfcpp line 474 C/C++ Problem non-const reference parameter 'cptr', make it const or use a pointer [google-runtime-references] CacheFactory.hpp /geode-native/src/cppcache/include/gfcpp line 486 C/C++ Problem non-const reference parameter 'cachePtr', make it const or use a pointer [google-runtime-references] CacheFactory.hpp /geode-native/src/cppcache/include/gfcpp line 494 C/C++ Problem non-const reference parameter 'bytes', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 63 C/C++ Problem non-const reference parameter 'bytes', make it const or use a pointer [google-runtime-references] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 73 C/C++ Problem non-const reference parameter 'attrs', make it const or use a pointer [google-runtime-references] AttributesFactory.hpp /geode-native/src/cppcache/include/gfcpp line 376 C/C++ Problem non-const reference parameter 'arrayLength', make it const or use a pointer [google-runtime-references] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 835 C/C++ Problem non-const reference parameter 'arrayLength', make it const or use a pointer [google-runtime-references] PdxInstance.hpp /geode-native/src/cppcache/include/gfcpp line 422 C/C++ Problem non-const reference parameter 'arrayLength', make it const or use a pointer [google-runtime-references] PdxReader.hpp /geode-native/src/cppcache/include/gfcpp line 367 C/C++ Problem non-const reference parameter 'args', make it const or use a pointer [google-runtime-references] Execution.hpp /geode-native/src/cppcache/include/gfcpp line 109 C/C++ Problem non-const reference parameter 'action', make it const or use a pointer [google-runtime-references] ExpirationAttributes.hpp /geode-native/src/cppcache/include/gfcpp line 89 C/C++ Problem do not use namespace using-directives; use using-declarations instead [google-build-using-namespace] StatisticDescriptor.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 25 C/C++ Problem do not use namespace using-directives; use using-declarations instead [google-build-using-namespace] StatisticsType.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 25 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Cache.hpp /geode-native/src/cppcache/include/gfcpp line 191 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] CqQuery.hpp /geode-native/src/cppcache/include/gfcpp line 107 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Execution.hpp /geode-native/src/cppcache/include/gfcpp line 90 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Pool.hpp /geode-native/src/cppcache/include/gfcpp line 202 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Query.hpp /geode-native/src/cppcache/include/gfcpp line 68 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Query.hpp /geode-native/src/cppcache/include/gfcpp line 92 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] QueryService.hpp /geode-native/src/cppcache/include/gfcpp line 89 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] QueryService.hpp /geode-native/src/cppcache/include/gfcpp line 123 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 136 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 158 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 198 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 207 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 215 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 236 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 309 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 362 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 407 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 435 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 505 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 554 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 601 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 630 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 685 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 718 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 776 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 854 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 890 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 941 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1092 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1159 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1231 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1309 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1344 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1370 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1399 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] Region.hpp /geode-native/src/cppcache/include/gfcpp line 1431 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] ResultCollector.hpp /geode-native/src/cppcache/include/gfcpp line 83 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] StatisticsFactory.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 74 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] StatisticsFactory.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 85 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] StatisticsFactory.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 97 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] StatisticsFactory.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 106 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] StatisticsFactory.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 116 C/C++ Problem default arguments on virtual or override methods are prohibited [google-default-arguments] StatisticsFactory.hpp /geode-native/src/cppcache/include/gfcpp/statistics line 126 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] CacheFactory.hpp /geode-native/src/cppcache/include/gfcpp line 219 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] CacheFactory.hpp /geode-native/src/cppcache/include/gfcpp line 248 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] CacheFactory.hpp /geode-native/src/cppcache/include/gfcpp line 258 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] DataInput.hpp /geode-native/src/cppcache/include/gfcpp line 209 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] DataOutput.hpp /geode-native/src/cppcache/include/gfcpp line 213 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] Pool.hpp /geode-native/src/cppcache/include/gfcpp line 96 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] Pool.hpp /geode-native/src/cppcache/include/gfcpp line 101 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] Pool.hpp /geode-native/src/cppcache/include/gfcpp line 106 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] PoolFactory.hpp /geode-native/src/cppcache/include/gfcpp line 114 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] PoolFactory.hpp /geode-native/src/cppcache/include/gfcpp line 127 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] PoolFactory.hpp /geode-native/src/cppcache/include/gfcpp line 133 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] PoolFactory.hpp /geode-native/src/cppcache/include/gfcpp line 317 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] PoolFactory.hpp /geode-native/src/cppcache/include/gfcpp line 347 C/C++ Problem consider replacing 'long' with 'int64' [google-runtime-int] PoolFactory.hpp /geode-native/src/cppcache/include/gfcpp line 357 C/C++ Problem C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] DataOutput.hpp /geode-native/src/cppcache/include/gfcpp line 332 C/C++ Problem C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] DataOutput.hpp /geode-native/src/cppcache/include/gfcpp line 364 C/C++ Problem C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 295 C/C++ Problem C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 303 C/C++ Problem C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 316 C/C++ Problem C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 353 C/C++ Problem C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] Serializer.hpp /geode-native/src/cppcache/include/gfcpp line 397 C/C++ Problem C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] SharedPtr.hpp /geode-native/src/cppcache/include/gfcpp line 214 C/C++ Problem {noformat} > Public API includes should be clean of all warnings and style issues > -------------------------------------------------------------------- > > Key: GEODE-2492 > URL: https://issues.apache.org/jira/browse/GEODE-2492 > Project: Geode > Issue Type: Task > Components: native client > Reporter: Jacob S. Barrett > > Make the public API headers conform strictly to the Google C++ Style guide > rules. Use clang-tidy to detect and enforce correctness. > Doing so now limits any breaking changes in the future as a result of needing > to correct style issues in these files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)