[GitHub] geode pull request #398: Split the redis adapter into its own package

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/398#discussion_r101374277
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
---
    @@ -1330,21 +1360,12 @@ private void startMemcachedServer() {
       }
     
       private void startRedisServer() {
    -    int port = system.getConfig().getRedisPort();
    -    if (port != 0) {
    -      String bindAddress = system.getConfig().getRedisBindAddress();
    -      assert bindAddress != null;
    -      if 
(bindAddress.equals(DistributionConfig.DEFAULT_REDIS_BIND_ADDRESS)) {
    -        getLoggerI18n().info(
    -            
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_PORT_0,
    -            new Object[] {port});
    -      } else {
    -        getLoggerI18n().info(
    -            
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_BIND_ADDRESS_0_PORT_1,
    -            new Object[] {bindAddress, port});
    -      }
    -      this.redisServer = new GeodeRedisServer(bindAddress, port);
    -      this.redisServer.start();
    +    GeodeRedisService geodeRedisService = 
getService(GeodeRedisService.class);
    --- End diff --
    
    @metatype The plan is to have the Redis server registered as a service that 
`GemFireCacheImpl` will start when the right properties are set. 
`GeodeRedisService` is in core, but implemented by `GeodeRedisServiceImpl` as 
long as geode-redis is on the classpath.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---