----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56637/#review165556 -----------------------------------------------------------
Ship it! Ship It! - Jared Stewart On Feb. 14, 2017, 7 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56637/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 7 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk > Lund. > > > Repository: geode > > > Description > ------- > > refactor ServerStarterRule and LocatorStarterRule so that they can be created > without a Properties first. > > * this would ease the usage of thsee rules, so that it can always be used as > a rule and users don't have to worry about stopping the locator/server > manually. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java > f93498fcbcea0ec8d8f0b91a0367e9b6fb7d4ae1 > > Diff: https://reviews.apache.org/r/56637/diff/ > > > Testing > ------- > > precheckin successful > > This code change will also fix the currently failing integration tests. See > the change in MemberMBeanSecurityJUnitTest.java > > > Thanks, > > Jinmei Liao > >
