----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56519/#review165042 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On Feb. 9, 2017, 11:02 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56519/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 11:02 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, and Kevin Duling. > > > Bugs: GEODE-2458 > https://issues.apache.org/jira/browse/GEODE-2458 > > > Repository: geode > > > Description > ------- > > GEODE-2458: await expected JMX notifications in verifyMemberNotifications > > Note line 581 is calling this method which adds the atMost for all callers to > centralize the timeout: > > private ConditionFactory await() { > return Awaitility.await().atMost(2, MINUTES); > } > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java > 7ff5f02 > > Diff: https://reviews.apache.org/r/56519/diff/ > > > Testing > ------- > > RegionManagementDUnitTest > full precheckin in progress > > > Thanks, > > Kirk Lund > >
