[
https://issues.apache.org/jira/browse/GEODE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860316#comment-15860316
]
ASF subversion and git services commented on GEODE-2324:
--------------------------------------------------------
Commit 75b02565b272a4b1dc5763f768bfed26fbed3d18 in geode's branch
refs/heads/develop from [~gosullivan]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=75b0256 ]
[GEODE-2324] fixes to AcceptorImpl.close()
If the thread is interrupted during closing, just continue to shut down
what we can.
* Catch InterruptedException so cleanup continues.
* Remove top-level exception handler to avoid masking exceptions that
* could short-circuit shutdown.
* Fix a synchronization bug that could cause AcceptorImpl to try to shut
down twice.
* Fix what looks like a bug where if closing the socket throws an
IOException, we fail to shut anything else down, though we still have
ourselves marked as shut down.
> If AcceptorImpl is interrupted during shutdown, it does not clean up properly.
> ------------------------------------------------------------------------------
>
> Key: GEODE-2324
> URL: https://issues.apache.org/jira/browse/GEODE-2324
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Affects Versions: 1.0.0-incubating
> Reporter: Galen O'Sullivan
> Assignee: Galen O'Sullivan
>
> In {{AcceptorImpl.close()}}, the call to
> {{this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT,
> TimeUnit.MILLISECONDS))}} can throw an {{InterruptedException}}, in which
> case neither {pool} nor {{hsPool}} or anything else that comes after is
> properly closed and an error message is logged.
> I believe that the thread will be interrupted if a shutdown command is issued
> (for example, through gfsh), though I haven't created a reproduction yet.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
