If we think we'll eventually finish the feature then that sounds good.
On Thu, Feb 9, 2017 at 2:01 PM, Swapnil Bawaskar <sbawas...@pivotal.io> wrote: > Implementation for distributed transactions was started but has not been > completed yet. The tests may only be testing what has been implemented so > far, so I would vote not to remove these tests. > On Thu, Feb 9, 2017 at 1:57 PM Kirk Lund <kl...@apache.org> wrote: > > > My reasoning is simple: Apache Geode does not currently have a > distributed > > transactions feature. > > > > > > On Thu, Feb 9, 2017 at 12:03 PM, Dan Smith <dsm...@pivotal.io> wrote: > > > > > What's wrong with these tests? Are you saying there is coverage > > elsewhere? > > > > > > -Dan > > > > > > On Thu, Feb 9, 2017 at 12:02 PM, Kirk Lund <kl...@apache.org> wrote: > > > > > > > Do we really want our nightly build and precheckin runs to waste time > > > > running these tests? > > > > > > > > DistributedTransactionDUnitTest > > > > DistTXDebugDUnitTest > > > > DistTXOrderDUnitTest > > > > DistTXPersistentDebugDUnitTest > > > > DistTXRestrictionsDUnitTest > > > > DistTXWithDeltaDUnitTest > > > > DistributedTransactionDUnitTest > > > > PRDistTXDUnitTest > > > > PRDistTXWithVersionsDUnitTest > > > > > > > > There are also quite a few non-dunit tests for distributed > > transactions. > > > > > > > > -Kirk > > > > > > > > > >
