[
https://issues.apache.org/jira/browse/GEODE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854911#comment-15854911
]
ASF GitHub Bot commented on GEODE-2430:
---------------------------------------
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/393
GEODE-2430: Remove jar and zip files from test resources
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/geode GEODE-2430
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #393
----
commit 9070ea43b93311d3c14d856663d7db3363d57264
Author: Jared Stewart <jstew...@pivotal.io>
Date: 2017-02-03T20:53:38Z
GEODE-2430: Refactor ZipUtils
commit 7ba28e3052b72d5b000e52dc350dedd4d6e36a44
Author: Jared Stewart <jstew...@pivotal.io>
Date: 2017-02-06T22:54:49Z
GEODE-2430: Remove jar and zip files from test resources
----
> Remove binary files from test resources
> ---------------------------------------
>
> Key: GEODE-2430
> URL: https://issues.apache.org/jira/browse/GEODE-2430
> Project: Geode
> Issue Type: Improvement
> Components: management
> Reporter: Jared Stewart
> Assignee: Jared Stewart
> Fix For: 1.1.0
>
>
> We have some tests which rely on the following binary files:
> {code}
> +
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster.jar
> +
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config.zip
> +
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip
> +
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group1.jar
> +
> geode-core/src/test/resources/org/apache/geode/management/internal/configuration/group2.jar
> {code}
> We need to convert our tests to generate these files dynamically instead so
> that we don't have binary files checked into our repository.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
