For me, the "--tests" option seems to only work with the "test" task (not
"integrationTest" or "distributedTest" which I've brought up before).
Are you sure the BC tests aren't run during the "precheckin" task despite
not running with the "--tests" option?
On Mon, Feb 6, 2017 at 11:12 AM, Dan Smith <dsm...@pivotal.io> wrote:
> Or maybe an incomplete implementation? Looking into the code for
> VersionManager, I don't see it getting old versions of geode from any other
> location. And it looks like the code just logs a warning if it can't find
> the file and carries on!
>
> The tests that use this are using a parameterized runner that returns the
> list of other versions. But when I try to run those tests it doesn't seem
> to find any tests to run. I also don't see this test getting run as part of
> CI.
>
> ./gradlew geode-core:distributedTest --tests '*ClientServerMiscBCDUnitTest*
> '
> > No tests found for given includes: [*ClientServerMiscBCDUnitTest*]
>
> It looks to me like we're not actually running backwards compatibility
> tests at all.
>
> -Dan
>
> On Mon, Feb 6, 2017 at 10:34 AM, Anthony Baker <aba...@pivotal.io> wrote:
>
> > It looks like it was an incomplete removal:
> >
> > geode-core/build.gradle: testCompile project(':geode-old-versions')
> > geode-core/src/test/java/org/apache/geode/test/dunit/
> > standalone/VersionManager.java: File propFile = new
> > File("../../../geode-old-versions/build/geodeOldVersionClasspaths.txt");
> > geode-core/src/test/java/org/apache/geode/test/dunit/
> > standalone/VersionManager.java: propFile = new
> > File("../geode-old-versions/build/geodeOldVersionClasspaths.txt");
> > settings.gradle:include 'geode-old-versions'
> >
> > I noticed the geode-old-versions showed up in the src release as an empty
> > dir, which is probably not a good thing.
> >
> > Anthony
> >
> > > On Feb 3, 2017, at 4:24 PM, Dan Smith <dsm...@pivotal.io> wrote:
> > >
> > > One thing Hitesh and I noticed is that when you do a build, it creates
> a
> > > directory called geode-old-versions because there is a line in
> > > settings.gradle for a geode-old-versions project.
> > >
> > > Is this leftover cruft, or is it actually supposed to be there? I see a
> > > couple of references to geode-old-versions in the source as well.
> > >
> > > -Dan
> >
> >
>
