----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56332/#review164391 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On Feb. 6, 2017, 6:18 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56332/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 6:18 p.m.) > > > Review request for geode, Anthony Baker, Bruce Schuchardt, Darrel Schneider, > Jacob Barrett, Jinmei Liao, Jared Stewart, and Dan Smith. > > > Bugs: GEODE-2431 > https://issues.apache.org/jira/browse/GEODE-2431 > > > Repository: geode > > > Description > ------- > > GEODE-2431: Upgrade use of Awaitility from 1.7.0 to 2.0.0 > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java > 3c4fe7099fba4c574a01f98c36e4d9a5fa15c573 > geode-core/src/test/java/org/apache/geode/SystemFailureJUnitTest.java > 279d8ddff2620677f3c6a9dc89945b05c7631385 > > geode-core/src/test/java/org/apache/geode/cache/asyncqueue/AsyncEventQueueEvictionAndExpirationJUnitTest.java > bafb499f7f6894ebada8e105bed72650b24e3ab6 > > geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java > 2f9f867a0e5854e566cb445b24067a915d9c78f1 > > geode-core/src/test/java/org/apache/geode/cache/client/internal/LocatorLoadBalancingDUnitTest.java > bd8143ee23d36b5317b76797ee3f18640abc0873 > > geode-core/src/test/java/org/apache/geode/cache/client/internal/SingleHopClientExecutorSubmitTaskWithExceptionTest.java > 3a9ece91da5bbbe98404a72b32b4f72e05596dd2 > > geode-core/src/test/java/org/apache/geode/cache/query/cq/dunit/CqQueryTestListener.java > 79209ef9c9f4a74df7991bcaf123515270d041b5 > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryUsingPoolDUnitTest.java > 5a0d3fc5513dea36b6a816cbb20b73c92879c3e9 > geode-core/src/test/java/org/apache/geode/cache30/Bug44418JUnitTest.java > abb4a9f04456cc75677fa67306fa74c9353c92f3 > > geode-core/src/test/java/org/apache/geode/cache30/ClientMembershipDUnitTest.java > 37561630b089b2fc6dd23689f524be967f17a2e0 > > geode-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java > 978056327237df86662dc9174239b9b22714e926 > geode-core/src/test/java/org/apache/geode/cache30/ReconnectDUnitTest.java > 03ce0b81b946a268e6edd91b57bd834d9647ff1a > geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java > 2e80107b2f38652ac2457eb892f7967c97a0fe0a > geode-core/src/test/java/org/apache/geode/distributed/LocatorJUnitTest.java > fb412563fc30278e80a7102eb67bd434ab90988c > > geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerDUnitTest.java > 3b8da03299baa832c12a3e9f2ef833d3a6a4e8b6 > > geode-core/src/test/java/org/apache/geode/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java > 9b68b23d0fe2b6a6c5f96283d46e79b5a4a0602e > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java > 792a1fdabd4b3433cb16a93c89c30169eb227bc6 > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > 14fedc61e3a9f55444e0df86add6fd54a4a153bc > > geode-core/src/test/java/org/apache/geode/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java > c354c98219083b62d5f4ab5547eda47c41c3d389 > > geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java > a37aebd9e03ff40502d6807f2029c4cd86fce4a9 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegRecoveryJUnitTest.java > d6ee1ea89063bef174e2515ac341c7aa24d3cea0 > > geode-core/src/test/java/org/apache/geode/internal/cache/EntryEventImplTest.java > 07d7f4dd14c11559e507d4b5d8bdb68f075aacc3 > > geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java > d733ae0407edab6ee4ff60c9cba4ff64feb5144f > > geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java > 8c6d8b2e6fdc84562168d4d44d6a59436b0891f7 > > geode-core/src/test/java/org/apache/geode/internal/cache/GemFireCacheImplTest.java > 5f550e2fc14a8b86bbb93c70079e5a1ee137a9af > > geode-core/src/test/java/org/apache/geode/internal/cache/MultipleOplogsRollingFeatureJUnitTest.java > 85d19af7f0edd810b463795428408a47025839ee > > geode-core/src/test/java/org/apache/geode/internal/cache/OplogJUnitTest.java > 7df8982fd9c9ab57d78438469a84721c387b5379 > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionSingleHopDUnitTest.java > 43096d6ee36997fb70014e8ae4bdac5f591fab0a > > geode-core/src/test/java/org/apache/geode/internal/cache/SingleHopStatsDUnitTest.java > 0d57155aceea26623ec2a43764e8c4a8e8a474ad > > geode-core/src/test/java/org/apache/geode/internal/cache/TXManagerImplTest.java > 3a5de2f63646793223098e1ad0289a5253d6af43 > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/BlockingHARegionQueueJUnitTest.java > ee1cd6d6e8c845af03a95ee4d8ec442fa94168a3 > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARegionQueueJUnitTest.java > 43f1ac72bd2991d202762ea2aaa6a25340af66b0 > > geode-core/src/test/java/org/apache/geode/internal/cache/locks/TXLockServiceDUnitTest.java > 14267a4cc910aa37c5ab92eff53dee16d19c80eb > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java > 504c16b9cbadad9daefb60e2895090239ab37d55 > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java > 9479883cb4646a1f20a6d40661d2c663c494688c > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/ShutdownAllDUnitTest.java > 52d132766ffeef12c37c8a1f38cc3ea7caa6bc0d > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientInterestNotifyDUnitTest.java > f31fd709b65488a074c6219f1a5b67e870a7ab2d > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerForceInvalidateDUnitTest.java > 375279d15332dd780f0e92163ba0b4177ea90999 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableClientQueueSizeDUnitTest.java > 161ada44aa5810ba3e36896cf8fee2dc0407975d > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/HABug36738DUnitTest.java > c4032cb65e0c4c5ce11b713fd1f9e00e2190c4cd > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java > 391c9062517f0bd392552d6cf1ac850fafb4a6f3 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java > fbcbe3e32610449b3692051f189be4e1ce9489ba > > geode-core/src/test/java/org/apache/geode/internal/cache/wan/asyncqueue/AsyncEventQueueValidationsJUnitTest.java > 6c5d69cedb6306209d825f976e01db2a09b9a3b2 > > geode-core/src/test/java/org/apache/geode/internal/net/SSLSocketIntegrationTest.java > 90ed468b43801e090628db3b7e4507bb60667108 > > geode-core/src/test/java/org/apache/geode/internal/offheap/OutOfOffHeapMemoryDUnitTest.java > 034e96787a39773c4ab26d332ee699333a944ff8 > > geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationJUnitTest.java > 6feb81ed02d4bff4491bcbfb3c6e4597716baef4 > > geode-core/src/test/java/org/apache/geode/internal/statistics/StatSamplerIntegrationTest.java > 06827395c9fdf8ec643a4d39cbe8f2cbc01690ed > > geode-core/src/test/java/org/apache/geode/internal/statistics/StatisticsDistributedTest.java > c9be72fd0ea3076dc5a63083ccf764d09cad1991 > > geode-core/src/test/java/org/apache/geode/management/CacheManagementDUnitTest.java > 680579d47070a593b00045eec75a5b6a7dd261fa > > geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java > eb2e6625b9fa6e149d5eac96803396330e6ad905 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java > fde7580487f8b844320d982eba7282ac59c08c9b > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceUsingDirDUnitTest.java > fff7681176cdaf16a4a3da5bc6d58406dcdcf83d > > geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java > b1e7765558f52ef825e9cce67b88bd09878f8ced > > geode-core/src/test/java/org/apache/geode/security/PDXGfshPostProcessorOnRemoteServerTest.java > 3fc3864481177ece3b5806690fcfc89136c474c2 > > geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java > f6105e11de36c83127592976c4a050614a08a5ce > geode-core/src/test/java/org/apache/geode/test/dunit/Invoke.java > 002abd4fe2d2fbb3fa264efbb3a7f52bf404e62d > > geode-core/src/test/java/org/apache/geode/test/dunit/RepeatableRunnable.java > 57edf5887e8a2d129892099999826500d28e9b95 > > geode-core/src/test/java/org/apache/geode/test/dunit/StoppableWaitCriterion.java > bea1ca28f763fad30dcd6f86d3acca2683b10cd8 > geode-core/src/test/java/org/apache/geode/test/dunit/VM.java > 6055f8b9f4bd08415406977ad752f2a58c8f0c7a > geode-core/src/test/java/org/apache/geode/test/dunit/Wait.java > f25810e7f84a3f82036f38cc41746ffb9028b792 > geode-core/src/test/java/org/apache/geode/test/dunit/WaitCriterion.java > 332fe848204aa48d0877608fcf2fc4d21db65589 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > c74d6c7e2053deb32ef8dce2f5eae79277d69534 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerConfigurationRule.java > bbca60c6c868e1d521424ef46c788cb1d23e465b > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java > 6fc0d03ab317f1715a57bde378e6500b016c2549 > > geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java > 0ea7050cc77693de69d6924b32728df0de3ddfbc > > geode-cq/src/test/java/org/apache/geode/management/internal/cli/commands/ClientCommandsDUnitTest.java > 0f8f5a0f16d5bbd623c50f09fd6140920dea3e32 > > geode-cq/src/test/java/org/apache/geode/security/CQPDXPostProcessorDUnitTest.java > c8b6802a627a7c2d58c21e240826b5cd8b7e5dfa > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationIntegrationTest.java > b21d9c07e41d21f5ae9608b17563a2c64c4f445f > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java > 3b6146bff7a50bd8bbe863ac87de12f8d31ecc3c > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java > 644ed787e4fc22119bfe60aff37bf1c8b3b67f5d > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java > 59c14a296683d1984591e649f3af383c7c47b85f > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsDUnitTest.java > 1c8bc887883c465ccdbd4dc4cde2d7b432cdc346 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/management/LuceneManagementDUnitTest.java > ef4681c1d63daaee308b1bbe69f5b1fbe1d8c7d5 > > geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java > 7822caa9b973a98a94cadc7aded29c99213fa97a > > geode-rebalancer/src/test/java/org/apache/geode/cache/util/AutoBalancerIntegrationJUnitTest.java > 7c336b0513f546e0f55acfcd9cb2f3b9623455af > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/Simple2CacheServerDUnitTest.java > 9937cc051ec336e4700417251e5676bfc9fea769 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java > 3f7f4c207ab0952717cff195f62f19d043a0790d > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderDUnitTest.java > 6a932a94c2941d8056ebc1de427b5a1273444814 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java > 6c8ea79792e40d4cb9e4ff157e77086dd51108dc > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/NewWanAuthenticationDUnitTest.java > 7837463c04ba830a942eeb7bbd09819400a654de > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueOverflowDUnitTest.java > 08d9e07dceb17041abf2df5dbd97f84e3f26c89b > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java > bf5b661753dcfeaad9ab9b2f01213f82384d0a60 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderEventListenerDUnitTest.java > 2368a8eda4280488ab727b9e540f79b048b6bfa3 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueueDUnitTest.java > 64f94dd66404933945edac255be5db360a5805e4 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANConflationDUnitTest.java > 64f0e62cf790488028b5cc5c1ac9f069a76204b6 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java > ca5f476ceb2cb636270f18411866a43ecacebb84 > > geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java > dc801bea09c76c9c9deda4279684a22a7cbf109d > gradle/dependency-versions.properties > fbc76e012732f8193f75dd9f7cba7d5b10daec40 > gradle/test.gradle 40fa962379af319f0d17c4b2ca47805857a88da1 > > Diff: https://reviews.apache.org/r/56332/diff/ > > > Testing > ------- > > precheckin passed except for Flaky tests: LocatorDUnitTest, > LocatorUDPSecurityDUnitTest, LuceneQueriesPeerPRRedundancyDUnitTest (all 3 of > these pass when rerun) > > > Thanks, > > Kirk Lund > >
