[
https://issues.apache.org/jira/browse/GEODE-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847796#comment-15847796
]
ASF GitHub Bot commented on GEODE-1435:
---------------------------------------
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98798945
--- Diff: src/CMakeLists.txt ---
@@ -71,7 +71,7 @@ set(CPACK_PACKAGE_FILE_NAME
${CPACK_PACKAGE_NAME}-${PRODUCT_VERSION}-${CPACK_SYS
set(CPACK_INCLUDE_TOPLEVEL_DIRECTORY 0)
set(CPACK_PACKAGING_INSTALL_PREFIX "/${CPACK_PACKAGE_NAME}")
#set(CPACK_PACKAGE_DESCRIPTION_FILE "${CMAKE_CURRENT_SOURCE_DIR}/README")
-#set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE")
+set(CPACK_RESOURCE_FILE_LICENSE
"${CMAKE_CURRENT_SOURCE_DIR}/../dist/LICENSE")
--- End diff --
The `NOTICE` file should be included in the binary distribution as well.
> Update LICENSE for native client bundled dependencies
> -----------------------------------------------------
>
> Key: GEODE-1435
> URL: https://issues.apache.org/jira/browse/GEODE-1435
> Project: Geode
> Issue Type: Sub-task
> Components: native client
> Reporter: Anthony Baker
> Assignee: Jacob S. Barrett
>
> We need to declare attribution for any bundled dependencies in the native
> client source code. If we choose to include the native client in the binary
> distribution, we will need to declare those bundled libraries as well.
> See
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors.
> Affected files:
> - LICENSE, NOTICE (source distribution)
> - geode-assembly/src/main/dist/LICENSE, NOTICE (binary distribution)
> Initial list of bundled source dependencies:
> - MersenneTwister (src/tests/cpp/fwklib/MersenneTwister.*pp)
> The binary dependencies can be reviewed in
> geode-client-native/src/dependencies (some of these are not shipped though):
> - libxml2
> - xerces-c
> - openssl
> - ACE
> - antlr
> - sqlite
> - doxygen
> - gtest
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
